Hadoop Common
  1. Hadoop Common
  2. HADOOP-5782

Make formatting of BlockManager.java similar to FSNamesystem.java to simplify porting patch

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When block management code was refactored from FSNamesystem.java to BlockManager.java, some formatting changes are made. These changes make porting patches to BlockManager.java difficult.

      1. formatting.patch
        17 kB
        Suresh Srinivas
      2. formatting.patch
        15 kB
        Suresh Srinivas

        Issue Links

          Activity

          Hide
          Suresh Srinivas added a comment -

          Retaining most of the format from FSNamesystem.java, except some of the cases where line exceeded 80 chars and unnecessary spaces.

          Show
          Suresh Srinivas added a comment - Retaining most of the format from FSNamesystem.java, except some of the cases where line exceeded 80 chars and unnecessary spaces.
          Hide
          Raghu Angadi added a comment -

          +1. After applying this patch, the first patch attached to HADOOP-5780 applies cleanly just by changing the file name from FSNamesystem.java to BlockManager.java.

          IMHO personally, the small block of code in metaSave() I looked at, looks better with this patch

          I think this can committed without going through highly backlogged Hudson.. could you run test-patch yourself?

          Show
          Raghu Angadi added a comment - +1. After applying this patch, the first patch attached to HADOOP-5780 applies cleanly just by changing the file name from FSNamesystem.java to BlockManager.java. IMHO personally, the small block of code in metaSave() I looked at, looks better with this patch I think this can committed without going through highly backlogged Hudson.. could you run test-patch yourself?
          Hide
          Suresh Srinivas added a comment -

          Tests not included because the patch just formats the code. Here is the testpatch result:
          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
          [exec] Please justify why no tests are needed for this patch.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

          Show
          Suresh Srinivas added a comment - Tests not included because the patch just formats the code. Here is the testpatch result: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          Hide
          Suresh Srinivas added a comment -

          Reattaching the patch for the changed trunk. No unit tests added as this is formatting change. Here is the test-patch result:

          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
          [exec] Please justify why no tests are needed for this patch.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

          Show
          Suresh Srinivas added a comment - Reattaching the patch for the changed trunk. No unit tests added as this is formatting change. Here is the test-patch result: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          Hide
          Raghu Angadi added a comment -

          I just committed this. Thanks Suresh!

          Show
          Raghu Angadi added a comment - I just committed this. Thanks Suresh!
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12408742/formatting.patch
          against trunk revision 777761.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/384/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12408742/formatting.patch against trunk revision 777761. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/384/console This message is automatically generated.
          Hide
          Raghu Angadi added a comment -

          The above hudson error is expected since the patch is already committed. I forgot the resolve the issue last time.

          Show
          Raghu Angadi added a comment - The above hudson error is expected since the patch is already committed. I forgot the resolve the issue last time.

            People

            • Assignee:
              Suresh Srinivas
              Reporter:
              Suresh Srinivas
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development