Hadoop Common
  1. Hadoop Common
  2. HADOOP-5780

Fix slightly confusing log from "-metaSave" on NameNode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None

      Description

      After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left.

      e.g. :

      Metasave: Blocks waiting for replication: 1
      blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
      

      "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".

      We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

      1. HADOOP-5780.patch
        2 kB
        Raghu Angadi
      2. HADOOP-5780.patch
        3 kB
        Raghu Angadi
      3. HADOOP-5780.patch
        3 kB
        Raghu Angadi
      4. HADOOP-5780.hadoop-0.20.patch
        2 kB
        Jitendra Nath Pandey

        Activity

        Hide
        Raghu Angadi added a comment -

        attached patch would change the above message to :

        Metasave: Blocks waiting for replication: 1
        blk_6735500019364591152_0 MISSING (replicas: l: 0 d: 0 c: 2 e: 0) 74.6.132.200:50010(corrupt) :  192.168.0.107:50010(corrupt) :
        
        Show
        Raghu Angadi added a comment - attached patch would change the above message to : Metasave: Blocks waiting for replication: 1 blk_6735500019364591152_0 MISSING (replicas: l: 0 d: 0 c: 2 e: 0) 74.6.132.200:50010(corrupt) : 192.168.0.107:50010(corrupt) :
        Hide
        Raghu Angadi added a comment -

        Updated patch for trunk. Earlier one does not apply to current trunk.

        Show
        Raghu Angadi added a comment - Updated patch for trunk. Earlier one does not apply to current trunk.
        Hide
        Suresh Srinivas added a comment -

        "decommisioned" has a typo. It should be "decommissioned".

        Also not covered in the description - the patch includes additional useful information that identifies a block on a node as "corrupt" or "decommissioned".

        Show
        Suresh Srinivas added a comment - "decommisioned" has a typo. It should be "decommissioned". Also not covered in the description - the patch includes additional useful information that identifies a block on a node as "corrupt" or "decommissioned".
        Hide
        Raghu Angadi added a comment -

        Thanks Suresh. Updated patch fixes the spelling.

        Show
        Raghu Angadi added a comment - Thanks Suresh. Updated patch fixes the spelling.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        (Didn't intend to change the issue description in the last comment. Probably accidentally changed some invisible characters. Sorry.)

        Show
        Tsz Wo Nicholas Sze added a comment - (Didn't intend to change the issue description in the last comment. Probably accidentally changed some invisible characters. Sorry.)
        Hide
        Suresh Srinivas added a comment -

        +1

        Show
        Suresh Srinivas added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12407573/HADOOP-5780.patch
        against trunk revision 772960.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407573/HADOOP-5780.patch against trunk revision 772960. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/console This message is automatically generated.
        Hide
        Raghu Angadi added a comment -

        I just committed this.

        Show
        Raghu Angadi added a comment - I just committed this.
        Hide
        Jitendra Nath Pandey added a comment -

        Patch for hadoop-0.20

        Show
        Jitendra Nath Pandey added a comment - Patch for hadoop-0.20

          People

          • Assignee:
            Raghu Angadi
            Reporter:
            Raghu Angadi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development