Hadoop Common
  1. Hadoop Common
  2. HADOOP-5711

Change Namenode file close log to info

        Details

        • Type: Bug Bug
        • Status: Resolved
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.20.1
        • Component/s: None
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          It is hard to tell whether a file is closed or not from the Namenode log if the stateChangeLog is not set to debug level. It is better to log file close in info level.

          1. Text File
            5711_20090422.patch
            0.8 kB
            Tsz Wo Nicholas Sze
          2. Text File
            5711_20090428.patch
            0.8 kB
            Tsz Wo Nicholas Sze

            Activity

            Ascending order - Click to sort in descending order
            Tsz Wo Nicholas Sze created issue -
            Hide
            Permalink
            Tsz Wo Nicholas Sze added a comment -

            5711_20090422.patch: change log level

            Show
            Tsz Wo Nicholas Sze added a comment - 5711_20090422.patch: change log level
            Tsz Wo Nicholas Sze made changes -
            Field Original Value New Value
            Attachment 5711_20090422.patch [ 12406192 ]
            Hide
            Permalink
            Hairong Kuang added a comment -

            Maybe a more informative message is better, something like "file xx is closed by yy".

            Show
            Hairong Kuang added a comment - Maybe a more informative message is better, something like "file xx is closed by yy".
            Hide
            Permalink
            Tsz Wo Nicholas Sze added a comment -

            5711_20090428.patch: changed the message.

            Show
            Tsz Wo Nicholas Sze added a comment - 5711_20090428.patch: changed the message.
            Tsz Wo Nicholas Sze made changes -
            Attachment 5711_20090428.patch [ 12406719 ]
            Hide
            Permalink
            Hairong Kuang added a comment -

            +1

            Show
            Hairong Kuang added a comment - +1
            Tsz Wo Nicholas Sze made changes -
            Status Open [ 1 ] Patch Available [ 10002 ]
            Hadoop Flags [Reviewed]
            Assignee Tsz Wo (Nicholas), SZE [ szetszwo ]
            Hide
            Permalink
            Tsz Wo Nicholas Sze added a comment - 
                 [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.

            The change is trivial. Don't want to waste cycles in Hudson. Will commit it soon.

            Show
            Tsz Wo Nicholas Sze added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. The change is trivial. Don't want to waste cycles in Hudson. Will commit it soon.
            Hide
            Permalink
            Tsz Wo Nicholas Sze added a comment -

            I have committed this to 0.20.1 and above.

            Show
            Tsz Wo Nicholas Sze added a comment - I have committed this to 0.20.1 and above.
            Tsz Wo Nicholas Sze made changes -
            Status Patch Available [ 10002 ] Resolved [ 5 ]
            Fix Version/s 0.20.1 [ 12313866 ]
            Fix Version/s 0.21.0 [ 12313563 ]
            Resolution Fixed [ 1 ]
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-trunk #822 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/822/)
            . Change Namenode file close log to info.

            Show
            Hudson added a comment - Integrated in Hadoop-trunk #822 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/822/ ) . Change Namenode file close log to info.
            Owen O'Malley made changes -
            Component/s dfs [ 12310710 ]
            Tom White made changes -
            Fix Version/s 0.21.0 [ 12313563 ]

              People

              • Assignee:
                Tsz Wo Nicholas Sze
                Reporter:
                Tsz Wo Nicholas Sze
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development