[HADOOP-5678] Mixed up #includes in c++ files.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: build

Environment

Fedora 10, gcc version 4.3.2 20081105 (Red Hat 4.3.2-7) (GCC)

• Assignee: Unassigned
• Reporter: Ricky Zhou
• Created: 15/Apr/09 06:54
• Updated: 04/May/09 23:29
• Resolved: 04/May/09 23:29

Description

src/c+/pipes/impl/HadoopPipes.cc, src/c/utils/impl/SerialUtils.cc, and src/c+/utils/impl/StringUtils.cc fail to compile due to some mixed up #includes.

When running ant -Dcompile.c+=true clean compile-c+ on svn trunk, I get errors about undeclared functions in the above files, such as:

[exec] /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc: In function 'uint64_t HadoopUtils::getCurrentMillis()':
[exec] /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc:74: error: 'strerror' was not declared in this scope
[exec] /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc: In function 'std::string HadoopUtils::quoteString(const std::string&, const char*)':
[exec] /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc:103: error: 'strchr' was not declared in this scope
[exec] /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc: In function 'std::string HadoopUtils::unquoteString(const std::string&)':
[exec] /home/ricky/h/test/hadoop-0.18.3/src/c++/utils/impl/StringUtils.cc:144: error: 'strtol' was not declared in this scope