Hadoop Common
  1. Hadoop Common
  2. HADOOP-5613

change S3Exception to checked exception

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.18.3
    • Fix Version/s: 0.21.0
    • Component/s: fs/s3
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the S3 filesystems can throw unchecked exceptions (S3Exception) which are not declared in the interface of FileSystem. These aren't caught by the various callers and can cause unpredictable behavior. IOExceptions are caught by most users of FileSystem since it is declared in the interface and hence is handled better.

      I propose we modify S3Exception to extend IOException.

      1. patch-ioexceptions.patch
        0.6 kB
        Andrew Hitchcock

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        4m 33s 1 Andrew Hitchcock 02/Apr/09 09:14
        Patch Available Patch Available In Progress In Progress
        13d 12h 33m 1 Andrew Hitchcock 15/Apr/09 21:47
        In Progress In Progress Resolved Resolved
        15d 17h 13m 1 Tom White 01/May/09 15:01
        Resolved Resolved Closed Closed
        480d 6h 35m 1 Tom White 24/Aug/10 21:36
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #824 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/824/ )
        Tom White made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Assignee Andrew Hitchcock [ anhi ]
        Fix Version/s 0.21.0 [ 12313563 ]
        Resolution Fixed [ 1 ]
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Andrew!

        Show
        Tom White added a comment - I've just committed this. Thanks Andrew!
        Hide
        Andrew Hitchcock added a comment -

        The test failure appears unrelated to my change.

        If there are no objections, can this be committed?

        Show
        Andrew Hitchcock added a comment - The test failure appears unrelated to my change. If there are no objections, can this be committed?
        Andrew Hitchcock made changes -
        Status Patch Available [ 10002 ] In Progress [ 3 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12404421/patch-ioexceptions.patch
        against trunk revision 761082.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12404421/patch-ioexceptions.patch against trunk revision 761082. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/99/console This message is automatically generated.
        Andrew Hitchcock made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Andrew Hitchcock made changes -
        Field Original Value New Value
        Attachment patch-ioexceptions.patch [ 12404421 ]
        Andrew Hitchcock created issue -

          People

          • Assignee:
            Andrew Hitchcock
            Reporter:
            Andrew Hitchcock
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development