Hadoop Common
  1. Hadoop Common
  2. HADOOP-5612

Some c++ scripts are not chmodded before ant execution

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.2
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Before executing a lot of the configure scripts, there are lines like:
      <chmod file="$

      {c++.libhdfs.src}

      /configure" perm="ugo+x"/>

      that ensure the configure script is executable (since they seem to not always make it into the distribution in this form).

      These chmods are missing for Pipes and C++ Utils which makes the build fail.

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12404385/0001-HADOOP-5612-Add-chmod-rules-to-build.xml-to-make.patch
        against trunk revision 761082.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/95/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/95/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/95/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/95/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12404385/0001-HADOOP-5612-Add-chmod-rules-to-build.xml-to-make.patch against trunk revision 761082. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/95/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/95/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/95/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/95/console This message is automatically generated.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Todd!

        Show
        Tom White added a comment - I've just committed this. Thanks Todd!
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #824 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/824/ )
        Hide
        Todd Lipcon added a comment -

        This should be committed to branch-0.20 as well, since it causes a fail to build from release source on many systems.

        Show
        Todd Lipcon added a comment - This should be committed to branch-0.20 as well, since it causes a fail to build from release source on many systems.
        Hide
        Chris Douglas added a comment -

        I required more changes to 0.20 to get this to build on MacOS (chmod install-sh as well). The error.h import in hdfsJniHelper.c also caused problems on MacOS, but doesn't appear to be required (on RHEL, anyway; errno is included in hdfsJniHelper.h, which covered all the defs I found). Todd, would you mind confirming in your environment?

        Show
        Chris Douglas added a comment - I required more changes to 0.20 to get this to build on MacOS (chmod install-sh as well). The error.h import in hdfsJniHelper.c also caused problems on MacOS, but doesn't appear to be required (on RHEL, anyway; errno is included in hdfsJniHelper.h, which covered all the defs I found). Todd, would you mind confirming in your environment?
        Hide
        Todd Lipcon added a comment -

        Todd, would you mind confirming in your environment?

        Works great still here (Ubuntu karmic). Thanks for the updated patch.

        [P.S. I grant my original patch under the Apache license.]

        Show
        Todd Lipcon added a comment - Todd, would you mind confirming in your environment? Works great still here (Ubuntu karmic). Thanks for the updated patch. [P.S. I grant my original patch under the Apache license.]
        Hide
        Chris Douglas added a comment -

        In looking to apply this to 0.21 and 0.22, it looks like the hdfsJniHelper.c change already has

        {,near-}

        identical fixes proposed in HDFS-467 and HDFS-829.

        Instead of complicating this further, I'm going to commit the original fix to 0.20 and try to get the MacOS changes into the prenominate JIRAs.

        Show
        Chris Douglas added a comment - In looking to apply this to 0.21 and 0.22, it looks like the hdfsJniHelper.c change already has {,near-} identical fixes proposed in HDFS-467 and HDFS-829 . Instead of complicating this further, I'm going to commit the original fix to 0.20 and try to get the MacOS changes into the prenominate JIRAs.
        Hide
        Chris Douglas added a comment -

        Committed to the 0.20 branch

        Show
        Chris Douglas added a comment - Committed to the 0.20 branch
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #164 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/164/)
        . Commit to branch 0.20

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #164 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/164/ ) . Commit to branch 0.20
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #248 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/248/)
        . Commit to branch 0.20

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #248 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/248/ ) . Commit to branch 0.20

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development