Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

        [javadoc] .\src\hdfs\org\apache\hadoop\hdfs\tools\JMXGet.java:45: warning:
       sun.management.ConnectorAddressLink is Sun proprietary API and may be removed in a future release
        [javadoc] import sun.management.ConnectorAddressLink;
        [javadoc]                      ^
        [javadoc] Standard Doclet version 1.6.0_07
        [javadoc] Building tree for all the packages and classes...
        [javadoc] .\src\hdfs\org\apache\hadoop\hdfs\tools\JMXGet.java:139: warning
       - @param argument "args" is not a parameter name.
      
      1. HADOOP-5507.patch
        10 kB
        Boris Shkolnik

        Activity

        Tsz Wo Nicholas Sze created issue -
        Hide
        Boris Shkolnik added a comment -

        removed sun.management.ConnectorAddressLink;
        instead user will have to run jstat to get the JMX connect url (see -help)

        also re-formatted the file.

        Show
        Boris Shkolnik added a comment - removed sun.management.ConnectorAddressLink; instead user will have to run jstat to get the JMX connect url (see -help) also re-formatted the file.
        Boris Shkolnik made changes -
        Field Original Value New Value
        Attachment HADOOP-5507.patch [ 12402401 ]
        Boris Shkolnik made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Boris Shkolnik added a comment -

        ran ant javadoc-dev

        0 warnings.

        Show
        Boris Shkolnik added a comment - ran ant javadoc-dev 0 warnings.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12402401/HADOOP-5507.patch
        against trunk revision 755589.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/101/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/101/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/101/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/101/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12402401/HADOOP-5507.patch against trunk revision 755589. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/101/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/101/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/101/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/101/console This message is automatically generated.
        Hide
        Boris Shkolnik added a comment -

        it is using same tests, this change was in argument procession only.

        Show
        Boris Shkolnik added a comment - it is using same tests, this change was in argument procession only.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Boris, the patch fixes the problem described in this issue. It also changes many code formatting. The formatting changes are good but it is unrelated to this issue. I will commit this for saving work cycles. Next time, please create new issues for fixing other problems. Otherwise, it would be hard to track issues.

        Show
        Tsz Wo Nicholas Sze added a comment - Boris, the patch fixes the problem described in this issue. It also changes many code formatting. The formatting changes are good but it is unrelated to this issue. I will commit this for saving work cycles. Next time, please create new issues for fixing other problems. Otherwise, it would be hard to track issues.
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags [Reviewed]
        Priority Major [ 3 ] Minor [ 4 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I committed this. Thanks, Boris!

        Show
        Tsz Wo Nicholas Sze added a comment - I committed this. Thanks, Boris!
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Tsz Wo Nicholas Sze made changes -
        Fix Version/s 0.21.0 [ 12313563 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk #785 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/785/)
        . Fix JMXGet javadoc warnings. (Boris Shkolnik via szetszwo)

        Show
        Hudson added a comment - Integrated in Hadoop-trunk #785 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/785/ ) . Fix JMXGet javadoc warnings. (Boris Shkolnik via szetszwo)
        Owen O'Malley made changes -
        Component/s dfs [ 12310710 ]
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        19h 46m 1 Boris Shkolnik 17/Mar/09 18:36
        Patch Available Patch Available Resolved Resolved
        2d 4h 40m 1 Tsz Wo Nicholas Sze 19/Mar/09 23:17
        Resolved Resolved Closed Closed
        522d 21h 19m 1 Tom White 24/Aug/10 21:36

          People

          • Assignee:
            Boris Shkolnik
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development