Hadoop Common
  1. Hadoop Common
  2. HADOOP-5464

DFSClient does not treat write timeout of 0 properly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.17.0
    • Fix Version/s: 1.1.0, 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Zero values for dfs.socket.timeout and dfs.datanode.socket.write.timeout are now respected. Previously zero values for these parameters resulted in a 5 second timeout.

      Description

      dfs.datanode.socket.write.timeout is used for sockets to and from datanodes. It is 8 minutes by default. Some users set this to 0, effectively disabling the write timeout (for some specific reasons).

      When this is set to 0, DFSClient sets the timeout to 5 seconds by mistake while writing to DataNodes. This is exactly the opposite of real intention of setting it to 0 since 5 seconds is too short.

      1. HADOOP-5464.branch1.patch
        1 kB
        Brandon Li
      2. HADOOP-5464.patch
        1 kB
        Raghu Angadi

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed the patch to branch-1 and branch-1.1. Thanks, Brandon!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed the patch to branch-1 and branch-1.1. Thanks, Brandon!
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 the branch-1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 the branch-1 patch looks good.
        Hide
        Brandon Li added a comment -

        Tests passed on my laptop with the back porting patch.

        Show
        Brandon Li added a comment - Tests passed on my laptop with the back porting patch.
        Hide
        Brandon Li added a comment -

        Backport the fix to branch 1.1

        Show
        Brandon Li added a comment - Backport the fix to branch 1.1
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #796 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/796/ )
        Hide
        Raghu Angadi added a comment -

        I just committed this.

        Show
        Raghu Angadi added a comment - I just committed this.
        Hide
        Raghu Angadi added a comment -

        Thanks Hairong. This is trivial change and doe not need a test.

        Show
        Raghu Angadi added a comment - Thanks Hairong. This is trivial change and doe not need a test.
        Hide
        Hairong Kuang added a comment -

        +1

        Show
        Hairong Kuang added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12401966/HADOOP-5464.patch
        against trunk revision 753449.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/65/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/65/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/65/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/65/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12401966/HADOOP-5464.patch against trunk revision 753449. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/65/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/65/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/65/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/65/console This message is automatically generated.
        Hide
        Raghu Angadi added a comment -

        patch for trunk.

        Show
        Raghu Angadi added a comment - patch for trunk.
        Hide
        Raghu Angadi added a comment -

        A work around is to use a very large value instead of 0.

        Show
        Raghu Angadi added a comment - A work around is to use a very large value instead of 0.

          People

          • Assignee:
            Raghu Angadi
            Reporter:
            Raghu Angadi
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development