Hadoop Common
  1. Hadoop Common
  2. HADOOP-5455

default "hadoop-metrics.properties" doesn't mention "rpc" context

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: documentation, metrics
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The "hadoop-metrics.properties" file that's shipped in conf/ has configuration settings for the metrics contexts "dfs", "mapred", and "jvm". The (trivial) patch I'm proposing is to include default configuration for the "rpc" context as well. RPC metrics may be useful, and it's difficult for a user to intuit otherwise that rpc metrics even exist. (I stumbled upon them after exploring with JConsole and JMX.)

      1. HADOOP-5455.patch
        0.7 kB
        Philip Zeyliger

        Activity

        Philip Zeyliger created issue -
        Hide
        Philip Zeyliger added a comment -

        Attaching modified hadoop-metrics.properties file. I've not added any tests since (to me) this is really simply a documentation improvement.

        Show
        Philip Zeyliger added a comment - Attaching modified hadoop-metrics.properties file. I've not added any tests since (to me) this is really simply a documentation improvement.
        Philip Zeyliger made changes -
        Field Original Value New Value
        Attachment HADOOP-5455.patch [ 12401859 ]
        Chris Douglas made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Philip Zeyliger [ philip ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12401859/HADOOP-5455.patch
        against trunk revision 752325.

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12401859/HADOOP-5455.patch against trunk revision 752325. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/68/console This message is automatically generated.
        Hide
        Tom White added a comment -

        +1

        Looks good to me. The test failure seems to be unrelated.

        Show
        Tom White added a comment - +1 Looks good to me. The test failure seems to be unrelated.
        Philip Zeyliger made changes -
        Summary default "hadoop-metrics.properties" doesn't mention "dfs" context default "hadoop-metrics.properties" doesn't mention "rpc" context
        Hide
        Chris Douglas added a comment -

        I committed this. Thanks, Philip

        Show
        Chris Douglas added a comment - I committed this. Thanks, Philip
        Chris Douglas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.21.0 [ 12313563 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #778 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/ )
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Philip Zeyliger
            Reporter:
            Philip Zeyliger
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development