Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-544

Replace the job, tip and task ids with objects.

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.18.0
    • 0.18.0
    • None
    • None
    • Incompatible change, Reviewed
    • Hide
      Introduced new classes JobID, TaskID and TaskAttemptID, which should be used instead of their string counterparts. Deprecated functions in JobClient, TaskReport, RunningJob, jobcontrol.Job and TaskCompletionEvent that use string arguments. Applications can use xxxID.toString() and xxxID.forName() methods to convert/restore objects to/from strings.
      Show
      Introduced new classes JobID, TaskID and TaskAttemptID, which should be used instead of their string counterparts. Deprecated functions in JobClient, TaskReport, RunningJob, jobcontrol.Job and TaskCompletionEvent that use string arguments. Applications can use xxxID.toString() and xxxID.forName() methods to convert/restore objects to/from strings.

    Description

      I think that it is silly to have tools parsing the strings that the framework builds for task ids. I propose:

      class JobId implements Writable {
      public int getJobId()

      {...}

      }

      class TaskId implements Writable {
      public JobId getJobId();
      public boolean isMap()

      { ... }
      public int getTaskId() { ... }

      }

      class TaskAttemptId implements Writable {
      public TaskId getTaskId();
      public int getAttemptId();
      }

      each of the classes will have a toString() method that generates the current string.

      Attachments

        1. id_wip1.patch
          8 kB
          Enis Soztutar
        2. id_v8.patch
          287 kB
          Enis Soztutar
        3. id_v7.patch
          278 kB
          Owen O'Malley
        4. id_v6.patch
          279 kB
          Enis Soztutar
        5. id_v5.patch
          278 kB
          Enis Soztutar
        6. id_v4.patch
          259 kB
          Enis Soztutar
        7. id_v3.patch
          213 kB
          Enis Soztutar
        8. id_v2.patch
          210 kB
          Enis Soztutar
        9. id_v1.patch
          193 kB
          Enis Soztutar

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            enis Enis Soztutar
            omalley Owen O'Malley
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment