Hadoop Common
  1. Hadoop Common
  2. HADOOP-5279

test-patch.sh scirpt should just call the test-core target as part of runtestcore function.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      checkReleaseAuditWarnings function just calls the releaseaudit target.
      checkFindbugsWarnings function just calls findbugs.

      runCoreTests function is calling docs tar and test-core.

      If we just want to execute the test-core target then we should skip calling docs and tar target ..

      1. HADOOP-5279.patch
        1 kB
        Giridharan Kesavan

        Activity

        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #763 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/763/ )
        Hide
        Nigel Daley added a comment -

        Yes, you're right Giri. I just committed this. Thanks!

        Show
        Nigel Daley added a comment - Yes, you're right Giri. I just committed this. Thanks!
        Hide
        Giridharan Kesavan added a comment -

        checkJavacWarnings function which is getting called after applying the patch which calls the tar ant target and which in turn has dependency on docs target. so I think we are good here.

        Show
        Giridharan Kesavan added a comment - checkJavacWarnings function which is getting called after applying the patch which calls the tar ant target and which in turn has dependency on docs target. so I think we are good here.
        Hide
        Nigel Daley added a comment -

        Ah, I remember why this was done. It's the only place in test-patch.sh that call the docs and tar target after the patch has been applied. Perhaps we need a runTar function that runs docs and tar targets. That would make a clearer failure if the patch breaks the build.

        Show
        Nigel Daley added a comment - Ah, I remember why this was done. It's the only place in test-patch.sh that call the docs and tar target after the patch has been applied. Perhaps we need a runTar function that runs docs and tar targets. That would make a clearer failure if the patch breaks the build.
        Hide
        Nigel Daley added a comment -

        +1.

        Show
        Nigel Daley added a comment - +1.
        Hide
        Giridharan Kesavan added a comment -

        this patch cannot be tested with hudson as it patches the test-patch.sh script itself.

        Show
        Giridharan Kesavan added a comment - this patch cannot be tested with hudson as it patches the test-patch.sh script itself.

          People

          • Assignee:
            Giridharan Kesavan
            Reporter:
            Giridharan Kesavan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development