Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.18.1, 0.18.2, 0.18.3, 0.19.0
    • Fix Version/s: 0.21.0
    • Component/s: benchmarks
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed

      Description

      When TestDFSIO starts up, it reports itself as "TestFSDIO", which would seem to be a typo.

      1. HADOOP-5176.patch
        0.9 kB
        Ravi Phulari
      2. HADOOP-5176.patch
        0.8 kB
        Ravi Phulari

        Activity

        Hide
        Robert Chansler added a comment -

        Editorial pass over all release notes prior to publication of 0.21. This was just a bug.

        Show
        Robert Chansler added a comment - Editorial pass over all release notes prior to publication of 0.21. This was just a bug.
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/ )
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12399843/HADOOP-5176.patch
        against trunk revision 742678.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3819/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3819/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3819/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3819/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12399843/HADOOP-5176.patch against trunk revision 742678. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3819/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3819/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3819/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3819/console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        This only changes TestDFSIO. I tested it manually. Everything works fine.

        I committed this. Thanks, Ravi!

        Show
        Tsz Wo Nicholas Sze added a comment - This only changes TestDFSIO. I tested it manually. Everything works fine. I committed this. Thanks, Ravi!
        Hide
        Ravi Phulari added a comment -

        Fixed two instances of wrong class name by following Nicholas's suggestion of using TestDFSIO.class.getSimpleName() instead of hard coding "TestDFSIO".

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 3 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total numberof release audit warnings.
        [exec]
        [exec]
        [exec]

        Show
        Ravi Phulari added a comment - Fixed two instances of wrong class name by following Nicholas's suggestion of using TestDFSIO.class.getSimpleName() instead of hard coding "TestDFSIO". [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total numberof release audit warnings. [exec] [exec] [exec]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Ravi Phulari added a comment -

        Fixed two instances of wrong class name by following Nicholas's suggestion of using TestDFSIO.class.getSimpleName() instead of hard coding "TestDFSIO".

        Show
        Ravi Phulari added a comment - Fixed two instances of wrong class name by following Nicholas's suggestion of using TestDFSIO.class.getSimpleName() instead of hard coding "TestDFSIO".
        Hide
        Ravi Phulari added a comment -

        Canceling patch to address Nicholas's comment .

        Show
        Ravi Phulari added a comment - Canceling patch to address Nicholas's comment .
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I think it is better to use TestDFSIO.class.getSimpleName() instead of hard coding "TestDFSIO".

        Show
        Tsz Wo Nicholas Sze added a comment - I think it is better to use TestDFSIO.class.getSimpleName() instead of hard coding "TestDFSIO".
        Hide
        Ravi Phulari added a comment -

        Submitting Patch , Incompatible changes command output .

        Show
        Ravi Phulari added a comment - Submitting Patch , Incompatible changes command output .
        Hide
        Ravi Phulari added a comment -

        Fixed two instances of wrong class name .

        Show
        Ravi Phulari added a comment - Fixed two instances of wrong class name .

          People

          • Assignee:
            Ravi Phulari
            Reporter:
            Bryan Duxbury
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development