Hadoop Common
  1. Hadoop Common
  2. HADOOP-5127

FSDirectory should not have public methods.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.19.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FSDirectory class contains public constructors and methods. All of them except for one close() can be converted into package private.

      1. HADOOP-5127-0-19.patch
        4 kB
        Konstantin Shvachko
      2. HADOOP-5127.patch
        3 kB
        Jakob Homan

        Activity

        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/ )
        Hide
        Konstantin Shvachko added a comment -

        This is the patch I applied to 0.20 and 0.19 branches.

        Show
        Konstantin Shvachko added a comment - This is the patch I applied to 0.20 and 0.19 branches.
        Hide
        Konstantin Shvachko added a comment -

        I just committed this. Thank you Jacob.

        Show
        Konstantin Shvachko added a comment - I just committed this. Thank you Jacob.
        Hide
        Jakob Homan added a comment -

        The failing test is called out in HADOOP-5127 as failing regularly.

        Show
        Jakob Homan added a comment - The failing test is called out in HADOOP-5127 as failing regularly.
        Hide
        Jakob Homan added a comment -

        The failing unit test on Hudson is a known-bad Chukwa test. I don't understand why it says both core tests and contrib tests failed, the results don't show that. The unit tests all passed on my machine except known-bad HADOOP-4907.

        Show
        Jakob Homan added a comment - The failing unit test on Hudson is a known-bad Chukwa test. I don't understand why it says both core tests and contrib tests failed, the results don't show that. The unit tests all passed on my machine except known-bad HADOOP-4907 .
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12399853/HADOOP-5127.patch
        against trunk revision 742698.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12399853/HADOOP-5127.patch against trunk revision 742698. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/console This message is automatically generated.
        Hide
        Konstantin Shvachko added a comment -

        +1 This looks good.

        Show
        Konstantin Shvachko added a comment - +1 This looks good.
        Hide
        Jakob Homan added a comment -

        Submitting patch

        Show
        Jakob Homan added a comment - Submitting patch
        Hide
        Jakob Homan added a comment -

        Patch:

        • Converts all public methods (except close) to package private.
        • Converts public class field boolean ready to private

        Passes all unit tests except the usual one.
        Test-patch:

             [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no tests are needed for this patch.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        

        No new unit tests because is just a visibility refactoring and not easily testable.

        Show
        Jakob Homan added a comment - Patch: Converts all public methods (except close) to package private. Converts public class field boolean ready to private Passes all unit tests except the usual one. Test-patch: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. No new unit tests because is just a visibility refactoring and not easily testable.

          People

          • Assignee:
            Jakob Homan
            Reporter:
            Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development