Hadoop Common
  1. Hadoop Common
  2. HADOOP-5101

optimizing build.xml target dependencies

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Need to optimize build.xml

      For ex: findbugs target depends on package target and package target depends on doc, jar, cn-docs , etc...
      Though findbugs is run on three of the jar files for which we have three different targets, jar, tools-jar , examples

      Likewise different targets could be optimized.

      Thanks,
      Giri

      1. hadoop-5101-v1.patch
        1 kB
        Giridharan Kesavan
      2. hadoop-5101.patch
        1 kB
        Giridharan Kesavan

        Activity

        Hide
        Sharad Agarwal added a comment -

        We would soon have to split the build.xml for different sub-projects - core, hdfs and mapred. So it might be better to do this optimization at that point.

        Show
        Sharad Agarwal added a comment - We would soon have to split the build.xml for different sub-projects - core, hdfs and mapred. So it might be better to do this optimization at that point.
        Hide
        Nigel Daley added a comment -

        I think it makes more sense to clean up the dependencies now, then it won't have to be repeated 3 times when the project is split.

        Show
        Nigel Daley added a comment - I think it makes more sense to clean up the dependencies now, then it won't have to be repeated 3 times when the project is split.
        Hide
        Sharad Agarwal added a comment -

        I think it makes more sense to clean up the dependencies now, then it won't have to be repeated 3 times when the project is split.

        I am fine with doing it now. Just I wanted to point out that splitting is going to happen soon so we do not do much rework.

        Show
        Sharad Agarwal added a comment - I think it makes more sense to clean up the dependencies now, then it won't have to be repeated 3 times when the project is split. I am fine with doing it now. Just I wanted to point out that splitting is going to happen soon so we do not do much rework.
        Hide
        Giridharan Kesavan added a comment -

        This optimization will only touch the more generalized targets like the releaseaudit and findbugs. This may not have impacts on the project split
        -Giri

        Show
        Giridharan Kesavan added a comment - This optimization will only touch the more generalized targets like the releaseaudit and findbugs. This may not have impacts on the project split -Giri
        Hide
        Giridharan Kesavan added a comment -

        This patch optimizes the findbugs targets, by calling only the required dependencies
        -Giri

        Show
        Giridharan Kesavan added a comment - This patch optimizes the findbugs targets, by calling only the required dependencies -Giri
        Hide
        Nigel Daley added a comment -

        Can we also combine test-c+-libhdfs target into the test target? Seems like test-c+-libhdfs will only be run if -Dlibhdfs=1 is set, right? So that should be safe.

        Show
        Nigel Daley added a comment - Can we also combine test-c+ -libhdfs target into the test target? Seems like test-c +-libhdfs will only be run if -Dlibhdfs=1 is set, right? So that should be safe.
        Hide
        Giridharan Kesavan added a comment -

        This patch incorporates Nigel's comments

        Show
        Giridharan Kesavan added a comment - This patch incorporates Nigel's comments
        Hide
        Nigel Daley added a comment -

        +1. Thanks Giri. Marking 'patch available'

        Show
        Nigel Daley added a comment - +1. Thanks Giri. Marking 'patch available'
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12398806/hadoop-5101-v1.patch
        against trunk revision 738329.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12398806/hadoop-5101-v1.patch against trunk revision 738329. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3765/console This message is automatically generated.
        Hide
        Nigel Daley added a comment -

        Test failures are unrelated to this build patch. No tests included since this is a build file fix.

        Show
        Nigel Daley added a comment - Test failures are unrelated to this build patch. No tests included since this is a build file fix.
        Hide
        Chris Douglas added a comment -

        I committed this. Thanks, Giri

        Show
        Chris Douglas added a comment - I committed this. Thanks, Giri
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/ )

          People

          • Assignee:
            Giridharan Kesavan
            Reporter:
            Giridharan Kesavan
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development