Hadoop Common
  1. Hadoop Common
  2. HADOOP-5088

include releaseaudit as part of test-patch.sh script

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Existing test-patch.sh script doesn't seem to execute releaseaudit target as part of patch testing.
      We need to call releaseaudit target from test-patch.sh script

      Thanks,
      Giri

      1. HADOOP-5088.patch
        3 kB
        Giridharan Kesavan
      2. HADOOP-5088-v1.patch
        3 kB
        Giridharan Kesavan

        Activity

        Hide
        Giridharan Kesavan added a comment -

        HADOOP-5088.patch calls the releaseaudit ant target when the patch is submitted to hudson.

        Executing of the release audit target consumes time, and didn't want the developer patch testing to be time consuming, so the releaseaudit target is called only when path is submitted to hudson.

        Hi Nigel,

        Could you please review the patch?

        Thanks,
        Giri

        Show
        Giridharan Kesavan added a comment - HADOOP-5088 .patch calls the releaseaudit ant target when the patch is submitted to hudson. Executing of the release audit target consumes time, and didn't want the developer patch testing to be time consuming, so the releaseaudit target is called only when path is submitted to hudson. Hi Nigel, Could you please review the patch? Thanks, Giri
        Hide
        Giridharan Kesavan added a comment -

        v1 version of patch execute's the releaseaudit target when the test -patch is called under DEVELOPER mode as well.

        Please review

        Show
        Giridharan Kesavan added a comment - v1 version of patch execute's the releaseaudit target when the test -patch is called under DEVELOPER mode as well. Please review
        Hide
        Nigel Daley added a comment -

        +1 code review. This change to the patch testing process can't be tested by Hudson.

        Show
        Nigel Daley added a comment - +1 code review. This change to the patch testing process can't be tested by Hudson.
        Hide
        Nigel Daley added a comment -

        I just committed this. Thanks Giri!

        Show
        Nigel Daley added a comment - I just committed this. Thanks Giri!
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/ )

          People

          • Assignee:
            Giridharan Kesavan
            Reporter:
            Giridharan Kesavan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development