Hadoop Common
  1. Hadoop Common
  2. HADOOP-5081

Split TestCLI into HDFS, Mapred and Core tests

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

      1. 5081_v1.patch
        301 kB
        Sharad Agarwal
      2. 5081_v2.patch
        302 kB
        Sharad Agarwal
      3. 5081_v3.patch
        303 kB
        Sharad Agarwal

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          3d 22h 53m 1 Sharad Agarwal 04/May/09 12:26
          Open Open Patch Available Patch Available
          100d 6h 46m 2 Sharad Agarwal 04/May/09 12:28
          Patch Available Patch Available Resolved Resolved
          21h 50m 1 Sharad Agarwal 05/May/09 10:18
          Resolved Resolved Closed Closed
          476d 11h 16m 1 Tom White 24/Aug/10 21:35
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk #827 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/827/)
          . Split TestCLI into HDFS, Mapred and Core tests.

          Show
          Hudson added a comment - Integrated in Hadoop-trunk #827 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/827/ ) . Split TestCLI into HDFS, Mapred and Core tests.
          Sharad Agarwal made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Sharad Agarwal added a comment -

          I just committed this.

          Show
          Sharad Agarwal added a comment - I just committed this.
          Sharad Agarwal made changes -
          Attachment 5081_v3.patch [ 12407225 ]
          Hide
          Sharad Agarwal added a comment -

          added license header in TestHDFSCLI and TestMRCLI

          Show
          Sharad Agarwal added a comment - added license header in TestHDFSCLI and TestMRCLI
          Hide
          Sharad Agarwal added a comment -

          test failures are unrelated.

          Show
          Sharad Agarwal added a comment - test failures are unrelated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12407145/5081_v2.patch
          against trunk revision 771525.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 664 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          -1 release audit. The applied patch generated 475 release audit warnings (more than the trunk's current 472 warnings).

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/testReport/
          Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/artifact/trunk/current/releaseAuditDiffWarnings.txt
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407145/5081_v2.patch against trunk revision 771525. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 664 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. -1 release audit. The applied patch generated 475 release audit warnings (more than the trunk's current 472 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/artifact/trunk/current/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/console This message is automatically generated.
          Hide
          Jothi Padmanabhan added a comment -

          +1.

          Show
          Jothi Padmanabhan added a comment - +1.
          Sharad Agarwal made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Sharad Agarwal made changes -
          Attachment 5081_v2.patch [ 12407145 ]
          Hide
          Sharad Agarwal added a comment -

          Incorporated review comments.

          Show
          Sharad Agarwal added a comment - Incorporated review comments.
          Sharad Agarwal made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jothi Padmanabhan added a comment -

          Some minor comments

          1. CommandExecutor.execute should ideally return a Results object instead of returning the executor itself
          2. There are quite a few assert statements that basically are no-ops as the condition would always return as true
          3. Remove unused import in TestCLI.java
          4. Remove the comment "// Start up mini mr cluster" in TestCLI.setup
          Show
          Jothi Padmanabhan added a comment - Some minor comments CommandExecutor.execute should ideally return a Results object instead of returning the executor itself There are quite a few assert statements that basically are no-ops as the condition would always return as true Remove unused import in TestCLI.java Remove the comment "// Start up mini mr cluster" in TestCLI.setup
          Sharad Agarwal made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Fix Version/s 0.21.0 [ 12313563 ]
          Sharad Agarwal made changes -
          Attachment 5081_v1.patch [ 12406919 ]
          Hide
          Sharad Agarwal added a comment -

          This patch:
          Splits the class TestCLI into TestCLI, TestHDFSCLI and TestMRCLI.
          Also it splits the test files into testConf.xml, testHDFSConf.xml, testMRConf.xml

          Show
          Sharad Agarwal added a comment - This patch: Splits the class TestCLI into TestCLI, TestHDFSCLI and TestMRCLI. Also it splits the test files into testConf.xml, testHDFSConf.xml, testMRConf.xml
          Sharad Agarwal made changes -
          Assignee Sharad Agarwal [ sharadag ]
          Nigel Daley made changes -
          Fix Version/s 0.20.0 [ 12313438 ]
          Sharad Agarwal made changes -
          Field Original Value New Value
          Link This issue blocks HADOOP-5135 [ HADOOP-5135 ]
          Ramya Sunil created issue -

            People

            • Assignee:
              Sharad Agarwal
              Reporter:
              Ramya Sunil
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development