Hadoop Common
  1. Hadoop Common
  2. HADOOP-5080

Update TestCLI with additional test cases.

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently TestCLI contains few of the dfs commands and verifies some of the error messages for quota and refreshServiceAcl.. Here is a proposal to add additional test cases to TestCLI to cover an exhaustive list of Hadoop commands. Here is a list of action items for the same:
      1) Complete the test cases for dfs commands which are not yet automated such as count, chmod, chown, chgrp etc
      2) Verify help messages in fs, dfsadmin, mradmin
      3) Add other Hadoop commands such as archives, dfsadmin, balancer, job, queue, version, jar, distcp, daemonlog etc to the command line test.

      1. HADOOP-5080-v2.patch
        680 kB
        V.Karthikeyan
      2. HADOOP-5080NEW.patch
        672 kB
        V.Karthikeyan
      3. TEST-org.apache.hadoop.cli.TestCLI.txt
        5.60 MB
        Ravi Phulari
      4. HADOOP-5080Update.patch
        673 kB
        V.Karthikeyan
      5. HADOOP-5080.patch
        673 kB
        V.Karthikeyan
      6. Hadoop-5080new.patch
        673 kB
        V.Karthikeyan
      7. Hadoop-5080New.patch
        673 kB
        V.Karthikeyan
      8. Hadoop-5080Updated.patch
        673 kB
        V.Karthikeyan
      9. TEST-org.apache.hadoop.cli.TestCLI.txt
        5.27 MB
        V.Karthikeyan
      10. hadoop-5080v1.patch
        673 kB
        V.Karthikeyan
      11. Hadoop-5080.patch
        671 kB
        V.Karthikeyan
      12. TestCLI.doc
        233 kB
        V.Karthikeyan
      13. hadoop5080.patch
        252 kB
        Ramya Sunil
      14. patch5080-v1.txt
        208 kB
        Ramya Sunil

        Activity

        Hide
        Nigel Daley added a comment -

        I would create a separate Jira for the split of this test into HDFS/MapRed/Core.

        Show
        Nigel Daley added a comment - I would create a separate Jira for the split of this test into HDFS/MapRed/Core.
        Hide
        Ramya Sunil added a comment - - edited

        Created a separate issue to split the command line test (TestCLI) into HDFS, Mapred and Core: HADOOP-5081. Thanks Nigel.

        Show
        Ramya Sunil added a comment - - edited Created a separate issue to split the command line test (TestCLI) into HDFS, Mapred and Core: HADOOP-5081 . Thanks Nigel.
        Hide
        Ramya Sunil added a comment -

        Attaching the initial version of the patch which contains a bunch of test cases for the remaining dfs commands : count, chmod, chown and chgrp.

        Show
        Ramya Sunil added a comment - Attaching the initial version of the patch which contains a bunch of test cases for the remaining dfs commands : count, chmod, chown and chgrp.
        Hide
        Ramya Sunil added a comment -

        Attaching a patch which contains all the hdfs commands and help messages. Karthik will be uploading the patch for non hdfs commands

        Show
        Ramya Sunil added a comment - Attaching a patch which contains all the hdfs commands and help messages. Karthik will be uploading the patch for non hdfs commands
        Hide
        V.Karthikeyan added a comment -

        Compiled and tested for local machine

        Show
        V.Karthikeyan added a comment - Compiled and tested for local machine
        Hide
        Iyappan Srinivasan added a comment -

        +1 reviewed the testcases and ran the testcases. Looks fine.

        Show
        Iyappan Srinivasan added a comment - +1 reviewed the testcases and ran the testcases. Looks fine.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12401607/Hadoop-5080.patch
        against trunk revision 751747.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1031 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/58/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/58/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/58/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/58/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12401607/Hadoop-5080.patch against trunk revision 751747. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1031 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/58/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/58/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/58/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/58/console This message is automatically generated.
        Hide
        Nigel Daley added a comment -

        I noticed that none of the test input paths contain any URIs (hdfs://, file://, etc). Why is that?

        Show
        Nigel Daley added a comment - I noticed that none of the test input paths contain any URIs (hdfs://, file:// , etc). Why is that?
        Hide
        V.Karthikeyan added a comment - - edited

        hdfs:// path is already mentioned in the testcases also "NAMENODE path" stands for "hdfs://namenode:portno/path".
        file:// is implicitly taken in the testcases when CLITEST_DATA is mentioned.
        please refer to the attached test scenarios.

        Show
        V.Karthikeyan added a comment - - edited hdfs:// path is already mentioned in the testcases also "NAMENODE path" stands for "hdfs://namenode:portno/path". file:// is implicitly taken in the testcases when CLITEST_DATA is mentioned. please refer to the attached test scenarios.
        Hide
        V.Karthikeyan added a comment -

        Version test case changed for buildname string pattern.
        Test case for /*/* globing in hdfs is also included.

        Show
        V.Karthikeyan added a comment - Version test case changed for buildname string pattern. Test case for /*/* globing in hdfs is also included.
        Hide
        Iyappan Srinivasan added a comment -

        Checked for these testcase changes and ran the testcases. it went fine.
        +1

        Show
        Iyappan Srinivasan added a comment - Checked for these testcase changes and ran the testcases. it went fine. +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12402023/TestCLI.doc
        against trunk revision 753346.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/63/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12402023/TestCLI.doc against trunk revision 753346. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/63/console This message is automatically generated.
        Hide
        Ramya Sunil added a comment -

        Cancelling the patch since Hudson picked the wrong one.

        Show
        Ramya Sunil added a comment - Cancelling the patch since Hudson picked the wrong one.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12402190/Hadoop-5080.patch
        against trunk revision 753600.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1033 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/88/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/88/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/88/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/88/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12402190/Hadoop-5080.patch against trunk revision 753600. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1033 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/88/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/88/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/88/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/88/console This message is automatically generated.
        Hide
        V.Karthikeyan added a comment -

        Nigel, can you please commit it.

        Show
        V.Karthikeyan added a comment - Nigel, can you please commit it.
        Hide
        Ravi Phulari added a comment -

        @ V.Karthikeyan
        I noticed that there are no -setSpaceQuota and -setQuota globbing test cases . Could you please add these two tests in your patch.
        Thanks,

        Show
        Ravi Phulari added a comment - @ V.Karthikeyan I noticed that there are no -setSpaceQuota and -setQuota globbing test cases . Could you please add these two tests in your patch. Thanks,
        Hide
        V.Karthikeyan added a comment -

        -setSpaceQuota and -setQuota globbing test cases Updated

        Ravi,
        could you please review and comment back,
        Thanks,

        Show
        V.Karthikeyan added a comment - -setSpaceQuota and -setQuota globbing test cases Updated Ravi, could you please review and comment back, Thanks,
        Hide
        Ravi Phulari added a comment -

        Thanks for adding globbing test cases Karthikeyan .
        I was unable to apply patch successfully it might be due to incompatible changes made before or after you submitted patch.
        Could you please resubmit patch created with current Trunk . Also please copy/paste your ant test results.

        Thanks ,
        Ravi

        Show
        Ravi Phulari added a comment - Thanks for adding globbing test cases Karthikeyan . I was unable to apply patch successfully it might be due to incompatible changes made before or after you submitted patch. Could you please resubmit patch created with current Trunk . Also please copy/paste your ant test results. Thanks , Ravi
        Hide
        V.Karthikeyan added a comment -

        Patch is Updated , also ant test results are attached

        Thanks,
        V.Karthikeyan

        Show
        V.Karthikeyan added a comment - Patch is Updated , also ant test results are attached Thanks, V.Karthikeyan
        Hide
        Ravi Phulari added a comment - - edited

        -1 ant test-core failed against current hadoop trunk.

        Test 643: version: display the version of current hadoop failed .

        ----------------------------------------------
        jar-test:
        [jar] Building jar: /home/rphulari/tasks/5080/hadoop/build/hadoop-0.21.0-dev-test.jar

        test-core:
        [mkdir] Created dir: /home/rphulari/tasks/5080/hadoop/build/test/data
        [mkdir] Created dir: /home/rphulari/tasks/5080/hadoop/build/test/logs
        [copy] Copying 1 file to /home/rphulari/tasks/5080/hadoop/build/test/extraconf
        [junit] Running org.apache.hadoop.cli.TestCLI
        [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 95.039 sec
        [junit] Test org.apache.hadoop.cli.TestCLI FAILED
        [junit] Running org.apache.hadoop.conf.TestConfiguration
        [junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 0.868 sec
        [junit] Running org.apache.hadoop.conf.TestConfigurationSubclass

        Log from TEST-org.apache.hadoop.cli.TestCLI.txt
        -------------------------------------
        2009-04-07 18:27:43,927 INFO cli.TestCLI (TestCLI.java:displayResults(233)) -
        2009-04-07 18:27:43,927 INFO cli.TestCLI (TestCLI.java:displayResults(237)) - Summary results:
        2009-04-07 18:27:43,927 INFO cli.TestCLI (TestCLI.java:displayResults(238)) - ----------------------------------

        2009-04-07 18:27:43,927 INFO cli.TestCLI (TestCLI.java:displayResults(258)) - Testing mode: test
        2009-04-07 18:27:43,927 INFO cli.TestCLI (TestCLI.java:displayResults(259)) -
        2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(260)) - Overall result: — FAIL —
        2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(262)) - # Tests pass: 642 (99%)
        2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(264)) - # Tests fail: 1 (0%)
        2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(266)) - # Validations done: 1860 (each test may do multiple validations)
        2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(269)) -
        2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(270)) - Failing tests:
        2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(271)) - --------------
        2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(277)) - 643: version: display the version of current hadoop
        2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(287)) -
        2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(288)) - Passing tests:
        2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(289)) - --------------
        2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(293)) - 1: ls: file using absolute path
        2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(293)) - 2: ls: file using relative path
        2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(293)) - 3: ls: files using globbing
        2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(293)) - 4: ls: directory using absolute path
        2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(293)) - 5: ls: directory using relative path

        Show
        Ravi Phulari added a comment - - edited -1 ant test-core failed against current hadoop trunk. Test 643: version: display the version of current hadoop failed . ---------------------------------------------- jar-test: [jar] Building jar: /home/rphulari/tasks/5080/hadoop/build/hadoop-0.21.0-dev-test.jar test-core: [mkdir] Created dir: /home/rphulari/tasks/5080/hadoop/build/test/data [mkdir] Created dir: /home/rphulari/tasks/5080/hadoop/build/test/logs [copy] Copying 1 file to /home/rphulari/tasks/5080/hadoop/build/test/extraconf [junit] Running org.apache.hadoop.cli.TestCLI [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 95.039 sec [junit] Test org.apache.hadoop.cli.TestCLI FAILED [junit] Running org.apache.hadoop.conf.TestConfiguration [junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 0.868 sec [junit] Running org.apache.hadoop.conf.TestConfigurationSubclass Log from TEST-org.apache.hadoop.cli.TestCLI.txt ------------------------------------- 2009-04-07 18:27:43,927 INFO cli.TestCLI (TestCLI.java:displayResults(233)) - 2009-04-07 18:27:43,927 INFO cli.TestCLI (TestCLI.java:displayResults(237)) - Summary results: 2009-04-07 18:27:43,927 INFO cli.TestCLI (TestCLI.java:displayResults(238)) - ---------------------------------- 2009-04-07 18:27:43,927 INFO cli.TestCLI (TestCLI.java:displayResults(258)) - Testing mode: test 2009-04-07 18:27:43,927 INFO cli.TestCLI (TestCLI.java:displayResults(259)) - 2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(260)) - Overall result: — FAIL — 2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(262)) - # Tests pass: 642 (99%) 2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(264)) - # Tests fail: 1 (0%) 2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(266)) - # Validations done: 1860 (each test may do multiple validations) 2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(269)) - 2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(270)) - Failing tests: 2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(271)) - -------------- 2009-04-07 18:27:43,928 INFO cli.TestCLI (TestCLI.java:displayResults(277)) - 643: version: display the version of current hadoop 2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(287)) - 2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(288)) - Passing tests: 2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(289)) - -------------- 2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(293)) - 1: ls: file using absolute path 2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(293)) - 2: ls: file using relative path 2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(293)) - 3: ls: files using globbing 2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(293)) - 4: ls: directory using absolute path 2009-04-07 18:27:43,929 INFO cli.TestCLI (TestCLI.java:displayResults(293)) - 5: ls: directory using relative path
        Hide
        V.Karthikeyan added a comment -

        1) Test for Version updated for http and https
        2) Tests updated for checking different TimeZones ( tests for dfsadmin - report and dfsadmin -refreshNodes)

        Show
        V.Karthikeyan added a comment - 1) Test for Version updated for http and https 2) Tests updated for checking different TimeZones ( tests for dfsadmin - report and dfsadmin -refreshNodes)
        Hide
        V.Karthikeyan added a comment -

        Testcase for version updated

        Show
        V.Karthikeyan added a comment - Testcase for version updated
        Hide
        Ravi Phulari added a comment -

        -1

        Testcase for version fails on GIT because testcase assumes version based on Subversion .
        Version testcase needs to be compatible with both git and subversion source .

         
        <!-- Test for Version -->
        +    <test> <!-- TESTED -->
        +      <description>version: display the version of current hadoop</description>
        +      <test-commands>
        +        <version-command>NAMENODE</version-command>
        +      </test-commands>
        +      <cleanup-commands>
        +        <!-- No cleanup -->
        +      </cleanup-commands>
        +      <comparators>
        +        <comparator>
        +          <type>RegexpComparator</type>
        +          <expected-output>^[Hh]adoop [0-9a-zA-Z\.\-_]+$</expected-output>
        +        </comparator>
        +        <comparator>
        +          <type>RegexpComparator</type>
        +          <expected-output>^Subversion [a-zA-Z\+]+:\/\/*/+.* -r [0-9]+$</expected-output>
        +        </comparator>
        +        <comparator>
        +          <type>RegexpComparator</type>
        +          <expected-output>^Compiled( )*by( )*[a-zA-Z0-9\.]+( )*on( )*[a-zA-Z]+( )*[a-zA-Z]+( )*[0-9]+( )*[0-9]+:[0-9]+:[0-9]+( )*[A-Z\-\+\:0-9]+( )*[0-9]+</expected-output>
        +        </comparator>
        +      </comparators>
        +    </test>
        
        

        Please verify your patch against git and svn Hadoop source.

        Thanks,

        Show
        Ravi Phulari added a comment - -1 Testcase for version fails on GIT because testcase assumes version based on Subversion . Version testcase needs to be compatible with both git and subversion source . <!-- Test for Version --> + <test> <!-- TESTED --> + <description> version: display the version of current hadoop </description> + <test-commands> + <version-command> NAMENODE </version-command> + </test-commands> + <cleanup-commands> + <!-- No cleanup --> + </cleanup-commands> + <comparators> + <comparator> + <type> RegexpComparator </type> + <expected-output> ^[Hh]adoop [0-9a-zA-Z\.\-_]+$ </expected-output> + </comparator> + <comparator> + <type> RegexpComparator </type> + <expected-output> ^Subversion [a-zA-Z\+]+:\/\/*/+.* -r [0-9]+$ </expected-output> + </comparator> + <comparator> + <type> RegexpComparator </type> + <expected-output> ^Compiled( )*by( )*[a-zA-Z0-9\.]+( )*on( )*[a-zA-Z]+( )*[a-zA-Z]+( )*[0-9]+( )*[0-9]+:[0-9]+:[0-9]+( )*[A-Z\-\+\:0-9]+( )*[0-9]+ </expected-output> + </comparator> + </comparators> + </test> Please verify your patch against git and svn Hadoop source. – Thanks,
        Hide
        V.Karthikeyan added a comment -

        Updates on test case for hadoop -version (Includes subversion and GIT)

        Show
        V.Karthikeyan added a comment - Updates on test case for hadoop -version (Includes subversion and GIT)
        Hide
        Ravi Phulari added a comment -

        -1 .
        Patch failed against git repository .

        Please update patch to pass version test with Haddop built from git source .

        bin/hadoop version from git source

         
        somehost:hadoop rphulari$ bin/hadoop version
        Hadoop 0.21.0-dev
        Subversion git://somehost/Users/rphulari/dev/git/hadoop -r 52ca5ddf89b9fc68aac6f05b4c6a8a0b755177bb
        Compiled by rphulari on Mon Apr 27 23:46:20 PDT 2009
        

        bin/hadoop version from svn source

        Hadoop 0.21.0-dev
        Subversion http://svn.apache.org/repos/asf/hadoop/core/trunk -r 769174
        Compiled by rphulari on Mon Apr 27 23:15:44 PDT 2009
        
        Show
        Ravi Phulari added a comment - -1 . Patch failed against git repository . Please update patch to pass version test with Haddop built from git source . bin/hadoop version from git source somehost:hadoop rphulari$ bin/hadoop version Hadoop 0.21.0-dev Subversion git://somehost/Users/rphulari/dev/git/hadoop -r 52ca5ddf89b9fc68aac6f05b4c6a8a0b755177bb Compiled by rphulari on Mon Apr 27 23:46:20 PDT 2009 bin/hadoop version from svn source Hadoop 0.21.0-dev Subversion http://svn.apache.org/repos/asf/hadoop/core/trunk -r 769174 Compiled by rphulari on Mon Apr 27 23:15:44 PDT 2009
        Hide
        V.Karthikeyan added a comment -

        Test case for hadoop -version command is updated to be more generic for GIT and SVN subversions

        Show
        V.Karthikeyan added a comment - Test case for hadoop -version command is updated to be more generic for GIT and SVN subversions
        Hide
        Ravi Phulari added a comment -

        -1 .
        Latest patch failed against git source ( Summary pasted below , log file is attached for reference ).

        HADOOP-4503 is already opened for null version information because of which version test case is failing .

        Karthikeyn could you please remove / comment-out version test cases and resubmit the patch.

        Thanks ,

         
        2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(202)) - -------------------------------------------
        2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(203)) - Test ID: [643]
        2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(204)) - Test Description: [version: display the version of current hadoop]
        2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(205)) -
        2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(209)) - Test Commands: [hdfs://localhost:32770]
        2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(213)) -
        2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(220)) -
        2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(224)) - Comparator: [RegexpComparator]
        2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(226)) - Comparision result: [pass]
        2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(228)) - Expected output: [^[Hh]adoop [0-9a-zA-Z\.\-_]+$]
        2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(230)) - Actual output: [Hadoop Unknown
        Subversion Unknown -r Unknown
        Compiled by Unknown on Unknown
        ]
        2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(224)) - Comparator: [RegexpComparator]
        2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(226)) - Comparision result: [fail]
        2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(228)) - Expected output: [^Compiled( )*by( )*[a-zA-Z0-9\.]+( )*on( )*[a-zA-Z]+( )*[a-zA-Z]+( )*[0-9]+( )*[0-9]+:[0-9]+:[0-9]+( )*[A-Z\-\+\:0-9]+( )*[0-9]+]
        2009-04-30 01:13:51,338 INFO cli.TestCLI (TestCLI.java:displayResults(230)) - Actual output: [Hadoop Unknown
        Subversion Unknown -r Unknown
        Compiled by Unknown on Unknown
        ]
        2009-04-30 01:13:51,338 INFO cli.TestCLI (TestCLI.java:displayResults(233)) - 
        
        Show
        Ravi Phulari added a comment - -1 . Latest patch failed against git source ( Summary pasted below , log file is attached for reference ). HADOOP-4503 is already opened for null version information because of which version test case is failing . Karthikeyn could you please remove / comment-out version test cases and resubmit the patch. Thanks , — 2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(202)) - ------------------------------------------- 2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(203)) - Test ID: [643] 2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(204)) - Test Description: [version: display the version of current hadoop] 2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(205)) - 2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(209)) - Test Commands: [hdfs://localhost:32770] 2009-04-30 01:13:51,336 INFO cli.TestCLI (TestCLI.java:displayResults(213)) - 2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(220)) - 2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(224)) - Comparator: [RegexpComparator] 2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(226)) - Comparision result: [pass] 2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(228)) - Expected output: [^[Hh]adoop [0-9a-zA-Z\.\-_]+$] 2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(230)) - Actual output: [Hadoop Unknown Subversion Unknown -r Unknown Compiled by Unknown on Unknown ] 2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(224)) - Comparator: [RegexpComparator] 2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(226)) - Comparision result: [fail] 2009-04-30 01:13:51,337 INFO cli.TestCLI (TestCLI.java:displayResults(228)) - Expected output: [^Compiled( )*by( )*[a-zA-Z0-9\.]+( )*on( )*[a-zA-Z]+( )*[a-zA-Z]+( )*[0-9]+( )*[0-9]+:[0-9]+:[0-9]+( )*[A-Z\-\+\:0-9]+( )*[0-9]+] 2009-04-30 01:13:51,338 INFO cli.TestCLI (TestCLI.java:displayResults(230)) - Actual output: [Hadoop Unknown Subversion Unknown -r Unknown Compiled by Unknown on Unknown ] 2009-04-30 01:13:51,338 INFO cli.TestCLI (TestCLI.java:displayResults(233)) -
        Hide
        Ravi Phulari added a comment -

        TestCLI log file

        Show
        Ravi Phulari added a comment - TestCLI log file
        Hide
        V.Karthikeyan added a comment -

        testcase for version removed

        Show
        V.Karthikeyan added a comment - testcase for version removed
        Hide
        Nigel Daley added a comment -

        Please comment on HADOOP-4503 that the version test case should be added back in as part of a patch for that Jira.

        Show
        Nigel Daley added a comment - Please comment on HADOOP-4503 that the version test case should be added back in as part of a patch for that Jira.
        Hide
        Ravi Phulari added a comment -

        +1
        Latest patch (HADOOP-5080NEW.patch) passed against both git and svn source .
        @ Karthikeyan thanks for updating patch.

        Show
        Ravi Phulari added a comment - +1 Latest patch ( HADOOP-5080 NEW.patch) passed against both git and svn source . @ Karthikeyan thanks for updating patch.
        Hide
        Sharad Agarwal added a comment -

        -1. TestCLI is failing on trunk.

        Overall result: — FAIL —
        [junit] 2009-05-05 12:15:09,801 INFO cli.TestCLI (TestCLI.java:displayResults(262)) - # Tests pass: 603 (93%)
        [junit] 2009-05-05 12:15:09,802 INFO cli.TestCLI (TestCLI.java:displayResults(264)) - # Tests fail: 39 (6%)
        [junit] 2009-05-05 12:15:09,802 INFO cli.TestCLI (TestCLI.java:displayResults(266)) - # Validations done: 1857 (each test may do multiple validations)

        Show
        Sharad Agarwal added a comment - -1. TestCLI is failing on trunk. Overall result: — FAIL — [junit] 2009-05-05 12:15:09,801 INFO cli.TestCLI (TestCLI.java:displayResults(262)) - # Tests pass: 603 (93%) [junit] 2009-05-05 12:15:09,802 INFO cli.TestCLI (TestCLI.java:displayResults(264)) - # Tests fail: 39 (6%) [junit] 2009-05-05 12:15:09,802 INFO cli.TestCLI (TestCLI.java:displayResults(266)) - # Validations done: 1857 (each test may do multiple validations)
        Hide
        Ravi Phulari added a comment -

        Changing summary to address only one issue of adding more test cases to TestCLI . Other issue of splitting TestCLI in 3 tests (HDFS,Mapred ,Core) is committed with Hadoop-5081.

        Show
        Ravi Phulari added a comment - Changing summary to address only one issue of adding more test cases to TestCLI . Other issue of splitting TestCLI in 3 tests (HDFS,Mapred ,Core) is committed with Hadoop-5081.
        Hide
        V.Karthikeyan added a comment -

        Patch updated to trunk
        -Split up of new test cases (as per Committed patch Hadoop-5081)

        Show
        V.Karthikeyan added a comment - Patch updated to trunk -Split up of new test cases (as per Committed patch Hadoop-5081)
        Hide
        Ravi Phulari added a comment -

        +1
        Verified on SVN and GIT trunk .
        Thanks Karthikeyan .

        Show
        Ravi Phulari added a comment - +1 Verified on SVN and GIT trunk . Thanks Karthikeyan .
        Hide
        Nigel Daley added a comment -

        Thanks Karthikeyan! I just committed this.

        Show
        Nigel Daley added a comment - Thanks Karthikeyan! I just committed this.

          People

          • Assignee:
            Unassigned
            Reporter:
            Ramya Sunil
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development