Hadoop Common
  1. Hadoop Common
  2. HADOOP-4862

A spurious IOException log on DataNode is not completely removed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.18.2
    • Fix Version/s: 0.19.1
    • Component/s: None
    • Labels:
      None
    • Environment:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Minor : HADOOP-3678 did not remove all the cases of spurious IOExceptions logged by DataNode.
      Show
      Minor : HADOOP-3678 did not remove all the cases of spurious IOExceptions logged by DataNode.

      Description

      HADOOP-3678 fixes a spurious warning log in DataNode, in most cases. This log is still possible in some cases.

      For e.g. The exception is still logged if the client closes the connection after DataNode writes all the block data but before it writes final 4 bytes to indicate end of data.

      1. HADOOP-4862-branch-18.patch
        3 kB
        Raghu Angadi
      2. HADOOP-4862.patch
        3 kB
        Raghu Angadi
      3. HADOOP-4862.patch
        3 kB
        Raghu Angadi

        Issue Links

          Activity

          Hide
          Raghu Angadi added a comment -

          Patch for 0.18. Not sure if it will be committed to 0.18.

          Show
          Raghu Angadi added a comment - Patch for 0.18. Not sure if it will be committed to 0.18.
          Hide
          Raghu Angadi added a comment -

          patch for trunk.

          Show
          Raghu Angadi added a comment - patch for trunk.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good, some nits:

          • "Convets" should be "Converts"
          • ioeToSocketException should be static
          • "Cange" should be "Change"
          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good, some nits: "Convets" should be "Converts" ioeToSocketException should be static "Cange" should be "Change"
          Hide
          Raghu Angadi added a comment -

          Thanks Nicholas.

          Updated patch has the suggested changes.

          Show
          Raghu Angadi added a comment - Thanks Nicholas. Updated patch has the suggested changes.
          Hide
          Raghu Angadi added a comment -

          output from test-patch :

               [exec]
               [exec] -1 overall.
               [exec]
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec]
               [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
               [exec]                         Please justify why no tests are needed for this patch.
               [exec]
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec]
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec]
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec]
               [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
          

          I have manually tested this and is relatively a minor issues. I don't think it needs a test case.

          Show
          Raghu Angadi added a comment - output from test-patch : [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. I have manually tested this and is relatively a minor issues. I don't think it needs a test case.
          Hide
          Raghu Angadi added a comment -

          I just committed this.

          Show
          Raghu Angadi added a comment - I just committed this.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12398438/HADOOP-4862.patch
          against trunk revision 738602.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          +1 core tests. The patch passed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3770/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3770/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3770/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3770/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12398438/HADOOP-4862.patch against trunk revision 738602. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3770/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3770/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3770/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3770/console This message is automatically generated.
          Hide
          Hudson added a comment -
          Show
          Hudson added a comment - Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/ )

            People

            • Assignee:
              Raghu Angadi
              Reporter:
              Raghu Angadi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development