This patch adds a -h flag to dfs -du and dfs -dus

It also refactors the two du functions to use the same code path and makes -du -s be synonymous with -dus

One breaking change is that the output format is now consistent between du and du -s, and it matches the Linux format (size on left, path on right). This may cause incompatibility with users who might parse the output of du, but I think it's worth it for consistency

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12407208/hadoop-4861.txt
against trunk revision 772920.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/300/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/300/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/300/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/300/console

This message is automatically generated.

Hudson failure is correct - I'll upload a fixed patch soon.

Fixes test cases

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12407845/hadoop-4861.txt
against trunk revision 774018.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 10 new or modified tests.

-1 patch. The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/330/console

This message is automatically generated.

Updated patch that should apply cleanly to trunk (previous one was broken by the splitting of the test dirs)

Slightly updated version of the patch which includes a unit test, and fixes du -h to write "150" for 150 bytes instead of "150.0"

Personally, I don't think backwards compatibility is critical here. I'd much rather have consistency between all the different options.

I briefly looked over the code and it seems to make sense, though I didn't have time to apply and test it.

Woops - forgot to include the new data1k file in my previous patch. This patch is identical code, just adds that file.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12408763/hadoop-4861.txt
against trunk revision 777761.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 23 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 release audit. The applied patch generated 492 release audit warnings (more than the trunk's current 491 warnings).

+1 core tests. The patch passed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/389/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/389/artifact/trunk/current/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/389/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/389/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/389/console

This message is automatically generated.

Test failures unrelated. The releaseAuditDiffWarnings.txt file linked by the QA bot doesn't load, but I am guessing it is warning that the "data1k" file has no Apache license. This is clearly correct.

I've just committed this. Thanks Todd!

Editorial pass over all release notes prior to publication of 0.21

Hello Todd,
Wondering why there is no command line help is not added with this patch. Also it did not update user documentation in System shell guide.

Hi Ravi,

Thanks for noticing this. That was an oversight - I'll open another JIRA momentarily against trunk and branch-21 to remedy it.

-Todd