Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-4796

Test target for chukwa build.xml needs to comply to hadoop build.xml test suites

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.0
    • Fix Version/s: 0.20.0
    • Component/s: build
    • Labels:
      None
    • Environment:

      Redhat EL 5, Java 6

    • Hadoop Flags:
      Reviewed

      Description

      Chukwa build.xml file is not honoring the hadoop test target. When calling ant -Dtest.include=mapred/Test* test, this command also executes chukwa test cases. The build.xml needs to be polished to avoid testing the wrong test cases.

      1. HADOOP-4796-2.patch
        36 kB
        Eric Yang
      2. HADOOP-4796.diff
        8 kB
        Eric Yang

        Issue Links

          Activity

          Hide
          chansler Robert Chansler added a comment -

          No release note for "just a bug."

          Show
          chansler Robert Chansler added a comment - No release note for "just a bug."
          Hide
          hudson Hudson added a comment -
          Show
          hudson Hudson added a comment - Integrated in Hadoop-trunk #683 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/683/ )
          Hide
          eyang Eric Yang added a comment -

          Thank you Chris.

          Show
          eyang Eric Yang added a comment - Thank you Chris.
          Hide
          chris.douglas Chris Douglas added a comment -

          +1 Looks good

          I just committed this. Thanks, Eric

          Show
          chris.douglas Chris Douglas added a comment - +1 Looks good I just committed this. Thanks, Eric
          Hide
          eyang Eric Yang added a comment -

          Same patch as above plus:

          Removed incompleted test cases for:

          • Agent to Collector communication test
          • Demux test (can't run without test data)
          • Log4j appender test case

          Removed unused library:

          ant.jar, ant-README.txt, ant-LICENSE.txt

          Show
          eyang Eric Yang added a comment - Same patch as above plus: Removed incompleted test cases for: Agent to Collector communication test Demux test (can't run without test data) Log4j appender test case Removed unused library: ant.jar, ant-README.txt, ant-LICENSE.txt
          Hide
          chris.douglas Chris Douglas added a comment -

          The patch looks good, but the following should be omitted:

          +              <!-- FIXME: Fix incompleted test cases -->
          +              <exclude name="**/TestDemux.java"/>
          +              <exclude name="**/TestAgentCollector.java"/>
          +              <exclude name="**/TestChukwaAppender.java"/>
          

          Assuming the tests themselves are invalid, they should be removed from the distribution and added back in a separate issue once they're fixed. Removing them as part of this patch would make sense.

          Show
          chris.douglas Chris Douglas added a comment - The patch looks good, but the following should be omitted: + <!-- FIXME: Fix incompleted test cases --> + <exclude name="**/TestDemux.java"/> + <exclude name="**/TestAgentCollector.java"/> + <exclude name="**/TestChukwaAppender.java"/> Assuming the tests themselves are invalid, they should be removed from the distribution and added back in a separate issue once they're fixed. Removing them as part of this patch would make sense.
          Hide
          eyang Eric Yang added a comment -

          Remove legacy test targets, test components are called dynamically.

          Show
          eyang Eric Yang added a comment - Remove legacy test targets, test components are called dynamically.
          Hide
          eyang Eric Yang added a comment -

          Chukwa test cases were divided into 5 categories:

          chunk
          input tools
          agent
          collector
          demux
          database

          There used to be test target for each components. Instead, this is changed to the same structure as Hadoop. Unit test can be executed like:

          ant -Dtestcase=TestChunk test
          ant -Dtest.include=adaptor/Test* test

          Show
          eyang Eric Yang added a comment - Chukwa test cases were divided into 5 categories: chunk input tools agent collector demux database There used to be test target for each components. Instead, this is changed to the same structure as Hadoop. Unit test can be executed like: ant -Dtestcase=TestChunk test ant -Dtest.include=adaptor/Test* test

            People

            • Assignee:
              eyang Eric Yang
              Reporter:
              eyang Eric Yang
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development