Hadoop Common
  1. Hadoop Common
  2. HADOOP-4794

separate branch for HadoopVersionAnnotation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I think we should pull out the "branch" in the HadoopVersionAnnotation and display it on the Web/UI.

      1. 4794-1.patch
        5 kB
        Chris Douglas
      2. 4794-0.patch
        5 kB
        Chris Douglas

        Activity

        Hide
        Owen O'Malley added a comment -

        For subversion, it would look like:

        url = "http://svn.apache.org/repos/asf/hadoop/core"
        branch = "branches/branch-0.18"

        For git, it would look like:

        url = "git://localhost/home/oom/hadoop-git"
        branch = "h1234"

        Show
        Owen O'Malley added a comment - For subversion, it would look like: url = "http://svn.apache.org/repos/asf/hadoop/core" branch = "branches/branch-0.18" For git, it would look like: url = "git://localhost/home/oom/hadoop-git" branch = "h1234"
        Hide
        Chris Douglas added a comment -

        Patch to saveVersion and jsps, adding the branch to the version annotation.

        A note on the implementation: for subversion, this takes the repository root and appends a prefix ("hadoop/core" by default) to build the url. The branch is whatever remains after the root + prefix (e.g. "branches/branch-0.19"). This permits non-canonical names for branches (e.g. "experimental/branchA" in addition to "branches/foo", "tags/bar", and "trunk"). Since most users observe the convention, supporting this use case may not be necessary.

        Show
        Chris Douglas added a comment - Patch to saveVersion and jsps, adding the branch to the version annotation. A note on the implementation: for subversion, this takes the repository root and appends a prefix ("hadoop/core" by default) to build the url. The branch is whatever remains after the root + prefix (e.g. "branches/branch-0.19"). This permits non-canonical names for branches (e.g. "experimental/branchA" in addition to "branches/foo", "tags/bar", and "trunk"). Since most users observe the convention, supporting this use case may not be necessary.
        Hide
        Chris Douglas added a comment -

        Alternative matching branches/*, tags/* or trunk.

        Show
        Chris Douglas added a comment - Alternative matching branches/*, tags/* or trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12396151/4794-1.patch
        against trunk revision 727660.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12396151/4794-1.patch against trunk revision 727660. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/console This message is automatically generated.
        Hide
        Owen O'Malley added a comment -

        I just committed this. Thanks, Chris!

        Show
        Owen O'Malley added a comment - I just committed this. Thanks, Chris!

          People

          • Assignee:
            Chris Douglas
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development