Hadoop Common
  1. Hadoop Common
  2. HADOOP-4632

TestJobHistoryVersion should not create directory in current dir.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.19.0
    • Fix Version/s: 0.19.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestJobHistoryVersion creates a directory, test-history-version, in the current dierctory. It should be created in test.build.data directory.

      1. HADOOP-4632-v1.patch
        0.7 kB
        Amar Kamat
      2. HADOOP-4632-v1.2.patch
        2 kB
        Amar Kamat
      3. HADOOP-4632-v1.1.patch
        0.7 kB
        Amar Kamat

        Activity

        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #680 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/680/ )
        Hide
        Chris Douglas added a comment -

        I just committed this. Thanks, Amar

        Show
        Chris Douglas added a comment - I just committed this. Thanks, Amar
        Hide
        Amareshwari Sriramadasu added a comment -

        +1 Patch looks good.

        Show
        Amareshwari Sriramadasu added a comment - +1 Patch looks good.
        Hide
        Amar Kamat added a comment -

        Attaching a new patch with the changes.

        Show
        Amar Kamat added a comment - Attaching a new patch with the changes.
        Hide
        Chris Douglas added a comment -

        test.build.data is shared by all the other unit tests; it shouldn't be the base for scratchwork.

        new Path(System.getProperty("test.build.data", "/tmp"), "testname")
        

        Is the normal idiom. The test directory should also be deleted when the tests have completed.

        Show
        Chris Douglas added a comment - test.build.data is shared by all the other unit tests; it shouldn't be the base for scratchwork. new Path( System .getProperty( "test.build.data" , "/tmp" ), "testname" ) Is the normal idiom. The test directory should also be deleted when the tests have completed.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12393786/HADOOP-4632-v1.1.patch
        against trunk revision 713612.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12393786/HADOOP-4632-v1.1.patch against trunk revision 713612. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/console This message is automatically generated.
        Hide
        Amareshwari Sriramadasu added a comment -

        +1

        Show
        Amareshwari Sriramadasu added a comment - +1
        Hide
        Amar Kamat added a comment -

        Attaching a new patch incorporating Amareshwari's comments.

        Show
        Amar Kamat added a comment - Attaching a new patch incorporating Amareshwari's comments.
        Hide
        Amareshwari Sriramadasu added a comment -

        The default TEST_DIR should not be /test-history-version, it can be inside /tmp.

        Show
        Amareshwari Sriramadasu added a comment - The default TEST_DIR should not be /test-history-version, it can be inside /tmp.
        Hide
        Amar Kamat added a comment -

        Attaching a patch the fixes the issue. Manually tested the patch.

        Show
        Amar Kamat added a comment - Attaching a patch the fixes the issue. Manually tested the patch.

          People

          • Assignee:
            Amar Kamat
            Reporter:
            Amareshwari Sriramadasu
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development