[HADOOP-4579] StorageDirectory is not removed from the storage directories list when writing to an edits fails

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.20.0
• Assignee: Boris Shkolnik
• Reporter: Boris Shkolnik
• Created: 03/Nov/08 21:11
• Updated: 08/Jul/09 16:43
• Resolved: 09/Dec/08 18:04

Description

If there is an IO Error on any log operations the directory should be removed from the list of active storage directories.
when it happens function FSEditLog:processIOError() is called.

in this function:
....
File parentStorageDir = ((EditLogFileOutputStream)editStreams.get(index)).getFile().getParentFile().getParentFile(); – which returns root
....
fsimage.processIOErrors(parentStorageDir);
...

which calles FSImage:ProcessIOErrors(dir).
but when dir is compared against list of storage dirs getParent is used instead of getPath()
so the match is never found.
....
if (sd.getRoot().getPath().equals(dirName.getParent())) { - should be dirName.getPath()
.....