Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-4483

getBlockArray in DatanodeDescriptor does not honor passed in maxblocks value

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 0.18.1
    • 0.18.2
    • None
    • None
    • hadoop-0.18.1 running on a cluster of 16 nodes.

    • Reviewed

    Description

      The getBlockArray method in DatanodeDescriptor.java should honor the passed in maxblocks parameter. In its current form it passed in an array sized to min(maxblocks,blocks.size()) into the Collections.toArray method. As the javadoc for Collections.toArray indicates, the toArray method may discard the passed in array (and allocate a new array) if the number of elements returned by the iterator exceeds the size of the passed in array. As a result, the flawed implementation of this method would return all the invalid blocks for a data node in one go, and thus trigger the NameNode to send a DNA_INVALIDATE command to the DataNode with an excessively large number of blocks. This INVALIDATE command, in turn, could potentially take a very long time to process at the DataNode, and since DatanodeCommand(s) are processed in between heartbeats at the DataNode, this would trigger the NameNode to consider the DataNode to be offline / unresponsive (due to a lack of heartbeats).

      In our use-case at CommonCrawl.org, we regularly do large scale hdfs file deletions after certain stages of our map-reduce pipeline. These deletes would make certain DataNode(s) unresponsive, and thus impact the cluster's capability to properly balance file-system reads / writes across the whole available cluster. This problem only surfaced once we migrated from our 16.2 deployment to the current 18.1 release.

      Attachments

        1. patch.HADOOP-4483
          1 kB
          Ahad Rana
        2. invalidateBlocksCopy-br18.patch
          4 kB
          Hairong Kuang
        3. invalidateBlocksCopy.patch
          4 kB
          Hairong Kuang
        4. HADOOP-4483-v3.patch
          6 kB
          Dhruba Borthakur
        5. HADOOP-4483-v3.patch
          2 kB
          Dhruba Borthakur
        6. HADOOP-4483-v2.patch
          2 kB
          Ahad Rana

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ahadr Ahad Rana
            ahadr Ahad Rana
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment