Hadoop Common
  1. Hadoop Common
  2. HADOOP-4466

SequenceFileOutputFormat is coupled to WritableComparable and Writable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.19.0
    • Fix Version/s: 0.19.0
    • Component/s: io
    • Labels:
      None
    • Release Note:
      Ensure that SequenceFileOutputFormat isn't tied to Writables and can be used with other Serialization frameworks.

      Description

      For some reason SequenceFileOutputFormat calls asSubclass() for OutputKeyClass and OutputValueClass. This throws a ClassCastException when using non-Writable types with the new Serialization framework.

      1. hadoop-4466.patch
        3 kB
        Chris K Wensel

        Activity

        Hide
        Chris K Wensel added a comment -

        Removes .asSubClass() calls that cast down to Writable and WritableComparable.

        Show
        Chris K Wensel added a comment - Removes .asSubClass() calls that cast down to Writable and WritableComparable.
        Hide
        Tom White added a comment -

        +1

        Show
        Tom White added a comment - +1
        Hide
        Chris K Wensel added a comment -

        All but org.apache.hadoop.fs.TestLocalDirAllocator tests pass.

        I think this is unrelated:
        shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory

        Show
        Chris K Wensel added a comment - All but org.apache.hadoop.fs.TestLocalDirAllocator tests pass. I think this is unrelated: shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
        Hide
        Chris K Wensel added a comment -

        via ant test-patch

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 3 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.

        Show
        Chris K Wensel added a comment - via ant test-patch [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        Hide
        Arun C Murthy added a comment -

        I just committed this. Thanks, Chris!

        Show
        Arun C Murthy added a comment - I just committed this. Thanks, Chris!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk #640 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/640/)
        . Ensure that SequenceFileOutputFormat isn't tied to Writables and can be used with other Serialization frameworks. Contributed by Chris Wensel.

        Show
        Hudson added a comment - Integrated in Hadoop-trunk #640 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/640/ ) . Ensure that SequenceFileOutputFormat isn't tied to Writables and can be used with other Serialization frameworks. Contributed by Chris Wensel.

          People

          • Assignee:
            Chris K Wensel
            Reporter:
            Chris K Wensel
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development