Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.17.2
    • Fix Version/s: 0.20.0
    • Component/s: conf, scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Changed processing of conf/slaves file to allow # to begin a comment.

      Description

      Support comments in 'slaves' file.
      Comments start with '#' (start of line or inline )

        Activity

        Hide
        Rama, Ramasamy added a comment -

        sed "s/#.*$//;/^$/d" : Remove anything after '#' and delete empty lines

        Show
        Rama, Ramasamy added a comment - sed "s/#.*$//;/^$/d" : Remove anything after '#' and delete empty lines
        Hide
        dhruba borthakur added a comment -

        I am not sure whether to mark this JIRA as an "incompatible" change or not. If a slaves file previously had an entry of the type:

        machine.xxx.com#bad

        then slaves.sh would fail while trying to connect to this machine because whereas with this patch slaves.sh will correctly interpret the machine name as machine.xxx.com and work correctly.

        Show
        dhruba borthakur added a comment - I am not sure whether to mark this JIRA as an "incompatible" change or not. If a slaves file previously had an entry of the type: machine.xxx.com#bad then slaves.sh would fail while trying to connect to this machine because whereas with this patch slaves.sh will correctly interpret the machine name as machine.xxx.com and work correctly.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12392400/comments_in_slaves.diff
        against trunk revision 706338.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12392400/comments_in_slaves.diff against trunk revision 706338. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3497/console This message is automatically generated.
        Hide
        Owen O'Malley added a comment -

        I just committed this. Thanks, Rama!

        I view this as a compatible change, since there are no legal hostnames with hash.

        Show
        Owen O'Malley added a comment - I just committed this. Thanks, Rama! I view this as a compatible change, since there are no legal hostnames with hash.
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #644 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/644/ )

          People

          • Assignee:
            Rama, Ramasamy
            Reporter:
            Rama, Ramasamy
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development