Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.17.0
    • Fix Version/s: 0.20.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the following code, when the blocks to be transferred has an invalid block, all the blocks that follow it are also not transferred. That might not be the intended behavior. Instead of breaking out of the loop, perhaps the right thing to do is to ignore the invalid block and continue with transferring the rest.

        private void transferBlocks( Block blocks[], 
                                     DatanodeInfo xferTargets[][] 
                                     ) throws IOException {
          for (int i = 0; i < blocks.length; i++) {
            if (!data.isValidBlock(blocks[i])) {
              String errStr = "Can't send invalid block " + blocks[i];
              LOG.info(errStr);
              namenode.errorReport(dnRegistration, 
                                   DatanodeProtocol.INVALID_BLOCK, 
                                   errStr);
              //
              // ******** This should be continue instead of break?
              //
              break;
            }
            int numTargets = xferTargets[i].length;
            if (numTargets > 0) {
              if (LOG.isInfoEnabled()) {
                StringBuilder xfersBuilder = new StringBuilder();
                for (int j = 0; j < numTargets; j++) {
                  DatanodeInfo nodeInfo = xferTargets[i][j];
                  xfersBuilder.append(nodeInfo.getName());
                  if (j < (numTargets - 1)) {
                    xfersBuilder.append(", ");
                  }
                }
                String xfersTo = xfersBuilder.toString();
                LOG.info(dnRegistration + " Starting thread to transfer block " + 
                         blocks[i] + " to " + xfersTo);                       
              }
              new Daemon(new DataTransfer(xferTargets[i], blocks[i], this)).start();
            }
          }
        }
      
      

        Attachments

        1. HADOOP-4388.patch
          0.6 kB
          Suresh Srinivas
        2. HADOOP-4388.patch
          0.6 kB
          Suresh Srinivas
        3. HADOOP-4388.patch
          1 kB
          Suresh Srinivas
        4. HADOOP-4388.patch
          3 kB
          Suresh Srinivas

          Activity

            People

            • Assignee:
              sureshms Suresh Srinivas
              Reporter:
              sureshms Suresh Srinivas
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: