Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.18.1
    • Fix Version/s: 0.18.2
    • Component/s: metrics
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics increments the metric.

      I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.

      Patch will be attached momentarily.

      1. hadoop-4369.patch
        0.7 kB
        Brian Bockelman

        Activity

        Brian Bockelman created issue -
        Hide
        Brian Bockelman added a comment -

        Patch to make averages actually averages in the Hadoops metric package.

        Show
        Brian Bockelman added a comment - Patch to make averages actually averages in the Hadoops metric package.
        Brian Bockelman made changes -
        Field Original Value New Value
        Attachment hadoop-4369.patch [ 12391692 ]
        Brian Bockelman made changes -
        Fix Version/s 0.18.1 [ 12313357 ]
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Owen O'Malley added a comment -

        0.18.1 has already been released.

        Show
        Owen O'Malley added a comment - 0.18.1 has already been released.
        Owen O'Malley made changes -
        Fix Version/s 0.18.1 [ 12313357 ]
        Fix Version/s 0.18.2 [ 12313424 ]
        Hide
        Johan Oskarsson added a comment -

        For some reason this hasn't been run through hudson, could you resubmit the patch Brian?

        Show
        Johan Oskarsson added a comment - For some reason this hasn't been run through hudson, could you resubmit the patch Brian?
        Nigel Daley made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Nigel Daley made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Robert Chansler made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Robert Chansler added a comment -

        See if Hudson will do the test.

        In any case, Nicholas will review the change.

        Promote for 19.

        Show
        Robert Chansler added a comment - See if Hudson will do the test. In any case, Nicholas will review the change. Promote for 19.
        Robert Chansler made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Robert Chansler made changes -
        Priority Major [ 3 ] Blocker [ 1 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags [Reviewed]
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        re-submitting ...

        Show
        Tsz Wo Nicholas Sze added a comment - re-submitting ...
        Tsz Wo Nicholas Sze made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -
         
            [exec] -1 overall.  
        
             [exec]     +1 @author.  The patch does not contain any @author tags.
        
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no tests are needed for this patch.
        
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
        
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
        
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
        
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        

        The change is simple. We don't need a new test here.

        Show
        Tsz Wo Nicholas Sze added a comment - [exec] -1 overall. [exec] +1 @author. The patch does not contain any @author tags. [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. The change is simple. We don't need a new test here.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        It passed all tests in my local machine.

        I just committed this. Thanks, Brian.

        Show
        Tsz Wo Nicholas Sze added a comment - It passed all tests in my local machine. I just committed this. Thanks, Brian.
        Tsz Wo Nicholas Sze made changes -
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Brian Bockelman [ bockelman ]
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #640 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/640/ )
        Nigel Daley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Brian Bockelman
            Reporter:
            Brian Bockelman
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 10m
              10m
              Remaining:
              Remaining Estimate - 10m
              10m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development