> ant -Dforrest.home=/XXX/forrest -Djava5.home=/usr/local/jdk1.5.0_07 -Dfindbugs.home=/XXX/findbugs -Dpatch.file=/home/zshao/HADOOP-4205.3.patch test-patch
...
[exec] +1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] +1 tests included. The patch appears to include 700 new or modified tests.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec] ======================================================================
[exec] ======================================================================
[exec] Finished build.
[exec] ======================================================================
[exec] ======================================================================
BUILD SUCCESSFUL
Total time: 8 minutes 27 seconds
I was able to remove 15 classes because the functionality is moved to (be shared with) serde and ObjectInspector.
List of files added:
A src/java/org/apache/hadoop/hive/ql/io/HiveKey.java
List of classes removed (15 classes + 2 tests):
D src/test/org/apache/hadoop/hive/ql/exec/TestCompositeHiveObject.java
D src/test/org/apache/hadoop/hive/ql/exec/TestWritables.java
D src/java/org/apache/hadoop/hive/ql/exec/PrimitiveHiveObject.java
D src/java/org/apache/hadoop/hive/ql/exec/NullHiveObject.java
D src/java/org/apache/hadoop/hive/ql/exec/HiveObject.java
D src/java/org/apache/hadoop/hive/ql/exec/TableHiveObject.java
D src/java/org/apache/hadoop/hive/ql/exec/CompositeHiveObject.java
D src/java/org/apache/hadoop/hive/ql/exec/LabeledCompositeHiveObject.java
D src/java/org/apache/hadoop/hive/ql/io/NaiiveJSONSerializer.java
D src/java/org/apache/hadoop/hive/ql/io/WritableComparableHiveObject.java
D src/java/org/apache/hadoop/hive/ql/io/NoTagHiveObjectComparator.java
D src/java/org/apache/hadoop/hive/ql/io/NaiiveSerializer.java
D src/java/org/apache/hadoop/hive/ql/io/NoTagWritableHiveObject.java
D src/java/org/apache/hadoop/hive/ql/io/HiveObjectComparator.java
D src/java/org/apache/hadoop/hive/ql/io/NoTagWritableComparableHiveObject.java
D src/java/org/apache/hadoop/hive/ql/io/HiveObjectSerializer.java
D src/java/org/apache/hadoop/hive/ql/io/WritableHiveObject.java
However the map/reduce boundary part is not optimized. I will optimize that together with DynamicSerDe.