Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.19.0
    • None
    • None
    • Reviewed

    Attachments

      1. hadoop-4186.patch
        14 kB
        Thomas White

      Activity

        tomwhite Thomas White added a comment -

        Patch that deprecates LineRecordReader.LineReader in favour of a new LineReader class in util.

        tomwhite Thomas White added a comment - Patch that deprecates LineRecordReader.LineReader in favour of a new LineReader class in util.
        cutting Doug Cutting added a comment -

        +1 This looks good to me.

        cutting Doug Cutting added a comment - +1 This looks good to me.
        wyckoff Pete Wyckoff added a comment -

        is the goal of this to create a LineReader deserializer? just wanted to know since i did do that for the unit tests for https://issues.apache.org/jira/browse/HADOOP-4065
        I have also implemented RecordIODeserializer .

        wyckoff Pete Wyckoff added a comment - is the goal of this to create a LineReader deserializer? just wanted to know since i did do that for the unit tests for https://issues.apache.org/jira/browse/HADOOP-4065 I have also implemented RecordIODeserializer .
        wyckoff Pete Wyckoff added a comment -

        Note this issue also relates to: https://issues.apache.org/jira/browse/HADOOP-4192 if we are starting to make Deserializers out of existing RecordReaders ...

        wyckoff Pete Wyckoff added a comment - Note this issue also relates to: https://issues.apache.org/jira/browse/HADOOP-4192 if we are starting to make Deserializers out of existing RecordReaders ...
        tomwhite Thomas White added a comment -

        is the goal of this to create a LineReader deserializer?

        No, it is purely to break the dependency that the core module has on mapred.

        tomwhite Thomas White added a comment - is the goal of this to create a LineReader deserializer? No, it is purely to break the dependency that the core module has on mapred.
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12390193/hadoop-4186.patch
        against trunk revision 696228.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/console

        This message is automatically generated.

        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12390193/hadoop-4186.patch against trunk revision 696228. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3284/console This message is automatically generated.
        omalley Owen O'Malley added a comment -

        I just committed this. Thanks, Tom!

        omalley Owen O'Malley added a comment - I just committed this. Thanks, Tom!
        hudson Hudson added a comment -
        hudson Hudson added a comment - Integrated in Hadoop-trunk #611 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/611/ )

        People

          tomwhite Thomas White
          tomwhite Thomas White
          Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved: