Hadoop Common
  1. Hadoop Common
  2. HADOOP-4161

[HOD] Uncaught exceptions can potentially hang hod-client.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.18.1
    • Component/s: contrib/hod
    • Labels:
      None

      Description

      In hod-client, we have

      sys.exit(hod.operation())
      sys.exit(hod.script())
      

      sys.exit(opCode) makes sure that the client is truly cleaned up, killing unjoined threads etc. So, exceptions not caught by hodRunner.operation() or hodRunner.script(), will by-pass sys.exit method and thus can potentially hang hod-client.

      For e.g., when hod allocate fails after allocation and before service-registry thread is cleaned up, hod client will hang.

      1. HADOOP-4161
        0.6 kB
        Vinod Kumar Vavilapalli

        Activity

        Hide
        Vinod Kumar Vavilapalli added a comment -

        Attaching a patch. A very small bug-fix. No test-cases and no documentation.

        Show
        Vinod Kumar Vavilapalli added a comment - Attaching a patch. A very small bug-fix. No test-cases and no documentation.
        Hide
        Hemanth Yamijala added a comment -

        Patch looks good. +1

        Show
        Hemanth Yamijala added a comment - Patch looks good. +1
        Hide
        Nigel Daley added a comment -

        I just committed this to trunk and branch-0.18. Thanks Vinod!

        Show
        Nigel Daley added a comment - I just committed this to trunk and branch-0.18. Thanks Vinod!

          People

          • Assignee:
            Vinod Kumar Vavilapalli
            Reporter:
            Vinod Kumar Vavilapalli
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development