Hadoop Common
  1. Hadoop Common
  2. HADOOP-3995

renameTo(src, dst) does not restore src name in case of quota failure.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.18.0
    • Fix Version/s: 0.18.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      In case of quota failure on HDFS, rename does not restore source filename.
      Show
      In case of quota failure on HDFS, rename does not restore source filename.

      Description

      How to reproduce :

      set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.

      • Now try : hadoop -mv src dst/diffname
        • This fails as expected
        • buf 'src' does not exist after this, you will find 'diffname' directory in its place

      I think fix should go into 0.18.1

      1. HADOOP-3995-018.patch
        2 kB
        Raghu Angadi
      2. HADOOP-3995-018.patch
        2 kB
        Raghu Angadi
      3. HADOOP-3995-trunk.patch
        2 kB
        Raghu Angadi

        Activity

        Hide
        Raghu Angadi added a comment -

        A simple fix is attached. This adds a test case in TestQuota

        Show
        Raghu Angadi added a comment - A simple fix is attached. This adds a test case in TestQuota
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12388759/HADOOP-3995-trunk.patch
        against trunk revision 688936.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12388759/HADOOP-3995-trunk.patch against trunk revision 688936. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/console This message is automatically generated.
        Hide
        Hairong Kuang added a comment -

        +1 The patch looks good.

        Show
        Hairong Kuang added a comment - +1 The patch looks good.
        Hide
        Raghu Angadi added a comment -

        Javadoc warnings are unrelated.

        Show
        Raghu Angadi added a comment - Javadoc warnings are unrelated.
        Hide
        Raghu Angadi added a comment -

        I just committeted this.

        Show
        Raghu Angadi added a comment - I just committeted this.
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #586 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/586/ )

          People

          • Assignee:
            Raghu Angadi
            Reporter:
            Raghu Angadi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development