Hadoop Common
  1. Hadoop Common
  2. HADOOP-3986

JobClient should not have a static configuration

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.18.0
    • Fix Version/s: 0.20.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Removed classes org.apache.hadoop.mapred.JobShell and org.apache.hadoop.mapred.TestJobShell. Removed from JobClient methods static void setCommandLineConfig(Configuration conf) and public static Configuration getCommandLineConfig().

      Description

      Post HADOOP-3743 use of static commandLineConfig and JobShell is deprecated. They should be removed.

      1. patch-3986.txt
        10 kB
        Amareshwari Sriramadasu

        Issue Links

          Activity

          Amareshwari Sriramadasu created issue -
          Amareshwari Sriramadasu made changes -
          Field Original Value New Value
          Link This issue is blocked by HADOOP-3676 [ HADOOP-3676 ]
          Hide
          Amareshwari Sriramadasu added a comment -

          This issue requires streaming and pipes to implement Tool.

          Show
          Amareshwari Sriramadasu added a comment - This issue requires streaming and pipes to implement Tool.
          Amareshwari Sriramadasu made changes -
          Link This issue is blocked by HADOOP-3722 [ HADOOP-3722 ]
          Amareshwari Sriramadasu made changes -
          Link This issue is blocked by HADOOP-3676 [ HADOOP-3676 ]
          Amareshwari Sriramadasu made changes -
          Link This issue is blocked by HADOOP-4612 [ HADOOP-4612 ]
          Hide
          Amareshwari Sriramadasu added a comment -

          Attaching patch which removes JobShell and static Configuration from JobClient.

          Show
          Amareshwari Sriramadasu added a comment - Attaching patch which removes JobShell and static Configuration from JobClient.
          Amareshwari Sriramadasu made changes -
          Attachment patch-3986.txt [ 12394317 ]
          Amareshwari Sriramadasu made changes -
          Fix Version/s 0.20.0 [ 12313438 ]
          Status Open [ 1 ] Patch Available [ 10002 ]
          Release Note Removes org.apache.hadoop.mapred.JobShell and org.apache.hadoop.mapred.TestJobShell classes.
          Removes apis : static void setCommandLineConfig(Configuration conf) and public static Configuration getCommandLineConfig() from org.apache.hadoop.mapred.JobClient
          Assignee Amareshwari Sriramadasu [ amareshwari ]
          Hadoop Flags [Incompatible change]
          Amareshwari Sriramadasu made changes -
          Component/s mapred [ 12310690 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12394317/patch-3986.txt
          against trunk revision 719787.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 10 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12394317/patch-3986.txt against trunk revision 719787. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/console This message is automatically generated.
          Hide
          Amareshwari Sriramadasu added a comment -

          Test failure org.apache.hadoop.hdfs.TestDatanodeBlockScanner.testBlockCorruptionRecoveryPolicy is not related to the patch.

          Show
          Amareshwari Sriramadasu added a comment - Test failure org.apache.hadoop.hdfs.TestDatanodeBlockScanner.testBlockCorruptionRecoveryPolicy is not related to the patch.
          Hide
          Chris Douglas added a comment -

          +1 Looks good. JobShell wasn't deprecated, but there has been ample warning since HADOOP-3743.

          I just committed this. Thanks Amareshwari

          Show
          Chris Douglas added a comment - +1 Looks good. JobShell wasn't deprecated, but there has been ample warning since HADOOP-3743 . I just committed this. Thanks Amareshwari
          Chris Douglas made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Incompatible change] [Incompatible change, Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk #670 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/670/)
          . Remove static Configuration from JobClient. Contributed by Amareshwari Sriramadasu.

          Show
          Hudson added a comment - Integrated in Hadoop-trunk #670 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/670/ ) . Remove static Configuration from JobClient. Contributed by Amareshwari Sriramadasu.
          Hide
          Robert Chansler added a comment -

          Edit release note for publication.

          Show
          Robert Chansler added a comment - Edit release note for publication.
          Robert Chansler made changes -
          Hadoop Flags [Reviewed, Incompatible change] [Incompatible change, Reviewed]
          Release Note Removes org.apache.hadoop.mapred.JobShell and org.apache.hadoop.mapred.TestJobShell classes.
          Removes apis : static void setCommandLineConfig(Configuration conf) and public static Configuration getCommandLineConfig() from org.apache.hadoop.mapred.JobClient
          Removed classes org.apache.hadoop.mapred.JobShell and org.apache.hadoop.mapred.TestJobShell. Removed from JobClient methods static void setCommandLineConfig(Configuration conf) and public static Configuration getCommandLineConfig().
          Nigel Daley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Owen O'Malley made changes -
          Component/s mapred [ 12310690 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          91d 2h 1m 1 Amareshwari Sriramadasu 20/Nov/08 06:43
          Patch Available Patch Available Resolved Resolved
          5d 2h 46m 1 Chris Douglas 25/Nov/08 09:30
          Resolved Resolved Closed Closed
          149d 9h 47m 1 Nigel Daley 23/Apr/09 20:17

            People

            • Assignee:
              Amareshwari Sriramadasu
              Reporter:
              Amareshwari Sriramadasu
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development