Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Since 8 July the nightly builds on Hudson have failed with the following error:

      [clover] Processing files at 1.3 source level.
      [clover] Updating database at '/zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-trunk/workspace/trunk/build/test/clover/db/hadoop_coverage.db'
      [clover] /var/tmp/clover35762.tmp/src35763.tmp/org/apache/hadoop/fs/FileUtil.java.tmp:508:10:unexpected token: OSType
      [clover] line 508: unexpected token: OSType
      [clover] ** Error(s) occurred and the instrumentation process can't continue.

      1. nightly2.patch
        1 kB
        Nigel Daley
      2. nightly.patch
        1 kB
        Tom White
      3. hadoop-3921.patch
        2 kB
        Tom White

        Issue Links

          Activity

          Hide
          Tom White added a comment -

          The changes that introduced the problem are listed here: http://hudson.zones.apache.org/hudson/view/Hadoop/job/Hadoop-trunk/540/. I wonder, could it be the change to Java 6 (HADOOP-2325)?

          Show
          Tom White added a comment - The changes that introduced the problem are listed here: http://hudson.zones.apache.org/hudson/view/Hadoop/job/Hadoop-trunk/540/ . I wonder, could it be the change to Java 6 ( HADOOP-2325 )?
          Hide
          Nigel Daley added a comment -

          yes, it was the change to java 6. I haven't had time to look at this yet. I think clover has an issue with the new class file format.

          Show
          Nigel Daley added a comment - yes, it was the change to java 6. I haven't had time to look at this yet. I think clover has an issue with the new class file format.
          Hide
          Nigel Daley added a comment -

          I have disabled clover in the nightly build until this can be addressed.

          Show
          Nigel Daley added a comment - I have disabled clover in the nightly build until this can be addressed.
          Hide
          Hudson added a comment -
          Show
          Hudson added a comment - Integrated in Hadoop-trunk #581 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/ )
          Hide
          Tom White added a comment -

          When we had the problem before we were using Clover 1. This patch updates the build to use Clover 2, which has some differences to do with how the ant task is defined: http://confluence.atlassian.com/display/CLOVER/1.+QuickStart+Guide. You now need to specify a clover.home property for ant.

          I tested with Clover 2.3.2 which is the version on Hudson, and it managed to instrument all the source (which is where it failed before), and run a test. I had to increase the memory available to ant to perform the instrumentation (see http://confluence.atlassian.com/pages/viewpage.action?pageId=79986966), using

          export ANT_OPTS=-Xmx256m
          

          I think we could try enabling this on Hudson again to see if it works.

          Show
          Tom White added a comment - When we had the problem before we were using Clover 1. This patch updates the build to use Clover 2, which has some differences to do with how the ant task is defined: http://confluence.atlassian.com/display/CLOVER/1.+QuickStart+Guide . You now need to specify a clover.home property for ant. I tested with Clover 2.3.2 which is the version on Hudson, and it managed to instrument all the source (which is where it failed before), and run a test. I had to increase the memory available to ant to perform the instrumentation (see http://confluence.atlassian.com/pages/viewpage.action?pageId=79986966 ), using export ANT_OPTS=-Xmx256m I think we could try enabling this on Hudson again to see if it works.
          Hide
          Nigel Daley added a comment -

          From a code review perspective, +1. I haven't run it.

          Show
          Nigel Daley added a comment - From a code review perspective, +1. I haven't run it.
          Hide
          Nigel Daley added a comment -

          I just committed this. Thanks Tom!

          Show
          Nigel Daley added a comment - I just committed this. Thanks Tom!
          Hide
          Tom White added a comment -

          A patch to re-instate Clover for the Hudson nightly build script (in http://svn.apache.org/repos/asf/hadoop/core/nightly).

          Nigel, does this look OK to you?

          Show
          Tom White added a comment - A patch to re-instate Clover for the Hudson nightly build script (in http://svn.apache.org/repos/asf/hadoop/core/nightly ). Nigel, does this look OK to you?
          Hide
          Nigel Daley added a comment -

          Looks good Tom. I committed it and re-enabled clover in Hadoop-trunk builds on Hudson.zones.

          Show
          Nigel Daley added a comment - Looks good Tom. I committed it and re-enabled clover in Hadoop-trunk builds on Hudson.zones.
          Hide
          Tom White added a comment -

          This caused the nightly Hudson build to fail (http://hudson.zones.apache.org/hudson/view/Hadoop/job/Hadoop-trunk/695/), so I've reverted it, pending investigation.

          Show
          Tom White added a comment - This caused the nightly Hudson build to fail ( http://hudson.zones.apache.org/hudson/view/Hadoop/job/Hadoop-trunk/695/ ), so I've reverted it, pending investigation.
          Hide
          Nigel Daley added a comment -

          I think this should fix it. The SUPPORT_LIB_DIR had an old version of clover in it and was getting copied into the lib dir.

          Show
          Nigel Daley added a comment - I think this should fix it. The SUPPORT_LIB_DIR had an old version of clover in it and was getting copied into the lib dir.
          Hide
          Nigel Daley added a comment -

          I just commited nightly2.patch. I'll watch this over the weekend and further tweak if necessary to get our code coverage builds back on track.

          Show
          Nigel Daley added a comment - I just commited nightly2.patch. I'll watch this over the weekend and further tweak if necessary to get our code coverage builds back on track.

            People

            • Assignee:
              Tom White
              Reporter:
              Tom White
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development