[HADOOP-3911] ' -blocks ' option not being recognized

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.19.0
• Component/s: fs, util

Environment

branch-0.18

• Hadoop Flags: Incompatible change, Reviewed
• Release Note: Added a check to fsck options to make sure -files is not the first option so as to resolve conflicts with GenericOptionsParser.
• Assignee: Lohit Vijaya Renu
• Reporter: Koji Noguchi
• Created: 06/Aug/08 19:40
• Updated: 20/Nov/08 23:38
• Resolved: 17/Sep/08 01:40

Description

Somehow depending on the order of options, GenericOptionsParser throws an error.

This fail.

[knoguchi@gsgw2001 tmp]$ ~/branch-0.18/bin/hadoop fsck
Usage: DFSck <path> [-move | -delete | -openforwrite] [-files [-blocks [-locations | -racks]]]

[knoguchi@tmp]$ ~/branch-0.18/bin/hadoop fsck -files -blocks -locations /user/knoguchi
java.io.FileNotFoundException: File -blocks does not exist.
        at org.apache.hadoop.util.GenericOptionsParser.validateFiles(GenericOptionsParser.java:278)
        at org.apache.hadoop.util.GenericOptionsParser.processGeneralOptions(GenericOptionsParser.java:233)
        at org.apache.hadoop.util.GenericOptionsParser.parseGeneralOptions(GenericOptionsParser.java:315)
        at org.apache.hadoop.util.GenericOptionsParser.<init>(GenericOptionsParser.java:134)
        at org.apache.hadoop.util.GenericOptionsParser.<init>(GenericOptionsParser.java:119)
        at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:59)
        at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:79)
        at org.apache.hadoop.dfs.DFSck.main(DFSck.java:137)

...Status: HEALTHY
 Total size:    2769 B
 Total dirs:    4
 Total files:   3
 Total blocks (validated):      3 (avg. block size 923 B)
...

This works.

[knoguchi@tmp]$ ~/branch-0.18/bin/hadoop fsck -blocks -locations -files /user/knoguchi
/user/knoguchi/.Trash <dir>
/user/knoguchi/hod-logs <dir>
/user/knoguchi/hod-logs/____ <dir>
/user/knoguchi/hod-logs/____/aaa.tar.gz 1024 bytes, 1 block(s):  OK
0. blk_-5724352734215884188_0 len=1024 repl=3 [11.111.11.11:11111, 22.22.22.22:11111, 33.33.33.33:11111]
...
/user/knoguchi/mapredsystem <dir>
Status: HEALTHY
 Total size:    2769 B
 Total dirs:    4
 Total files:   3
 Total blocks (validated):      3 (avg. block size 923 B)