Hadoop Common
  1. Hadoop Common
  2. HADOOP-3569

KFS input stream read() returns 4 bytes instead of 1

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.18.0
    • Fix Version/s: 0.18.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Fixed KFS to have read() read and return 1 byte instead of 4.

      Description

      The call to KFSInputStream:read() returns 4 bytes; it should return 1 byte (in conformance to java.io.inputstream read() signature).

      1. patch.3569
        2 kB
        Sriram Rao

        Activity

        Sriram Rao created issue -
        Sriram Rao made changes -
        Field Original Value New Value
        Attachment patch.3569 [ 12384077 ]
        Hide
        Lohit Vijayarenu added a comment -

        +1 looks good to me. Making this PA

        Show
        Lohit Vijayarenu added a comment - +1 looks good to me. Making this PA
        Lohit Vijayarenu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Sriram Rao [ sriramsrao ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12384077/patch.3569
        against trunk revision 668400.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2668/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2668/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2668/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2668/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12384077/patch.3569 against trunk revision 668400. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2668/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2668/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2668/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2668/console This message is automatically generated.
        Sriram Rao made changes -
        Comment [ > -1 tests included. The patch doesn't appear to include any new or modified tests.
        > Please justify why no tests are needed for this patch.

         The tests provided use a KFS emulation implementation via the localFS to test the APIs. In that sense, the existing tests cover the read() API. That said, testing of the code in fs/kfs/... requires a KFS deployment; this has always been done elsewhere and I then submit the code for inclusion.
        ]
        Sriram Rao made changes -
        Attachment patch.3569 [ 12384077 ]
        Hide
        Sriram Rao added a comment -

        Updated patch that contains the fix as well as a test case for this change.

        Show
        Sriram Rao added a comment - Updated patch that contains the fix as well as a test case for this change.
        Sriram Rao made changes -
        Attachment patch.3569 [ 12384221 ]
        Lohit Vijayarenu made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Lohit Vijayarenu added a comment -

        +1

        Show
        Lohit Vijayarenu added a comment - +1
        Lohit Vijayarenu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12384221/patch.3569
        against trunk revision 669088.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2685/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2685/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2685/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2685/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12384221/patch.3569 against trunk revision 669088. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2685/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2685/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2685/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2685/console This message is automatically generated.
        Hide
        Owen O'Malley added a comment -

        I just committed this. Thanks, Sriram!

        Show
        Owen O'Malley added a comment - I just committed this. Thanks, Sriram!
        Owen O'Malley made changes -
        Release Note Fixed KFS to have read() read and return 1 byte instead of 4.
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hadoop Flags [Incompatible change]
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #524 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/524/ )
        Nigel Daley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        1d 10h 35m 1 Lohit Vijayarenu 18/Jun/08 17:48
        Open Open Patch Available Patch Available
        12h 41m 2 Lohit Vijayarenu 18/Jun/08 17:49
        Patch Available Patch Available Resolved Resolved
        1d 1h 57m 1 Owen O'Malley 19/Jun/08 19:46
        Resolved Resolved Closed Closed
        64d 1h 4m 1 Nigel Daley 22/Aug/08 20:50

          People

          • Assignee:
            Sriram Rao
            Reporter:
            Sriram Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development