Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.18.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Some of the comments in fuse-dfs are not related to the codes. For example, search "facebook" in src/contrib/fuse-dfs/configure.ac

      1. patch0.txt
        7 kB
        Pete Wyckoff

        Activity

        Tsz Wo Nicholas Sze created issue -
        Hide
        Pete Wyckoff added a comment -

        Good catch - I used the default facebook external autoconf macros. I've changed these things internally and am awaiting my internal code review and will provide a patch shortly.

        Show
        Pete Wyckoff added a comment - Good catch - I used the default facebook external autoconf macros. I've changed these things internally and am awaiting my internal code review and will provide a patch shortly.
        Hide
        Pete Wyckoff added a comment -

        This is a change in autoconf only, no code changes.

        Show
        Pete Wyckoff added a comment - This is a change in autoconf only, no code changes.
        Pete Wyckoff made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Pete Wyckoff made changes -
        Attachment patch0.txt [ 12383317 ]
        Hide
        Pete Wyckoff added a comment -

        NOTE: I renamed some of the macros from FB_blah to FUSE_DFS_blah; longer term, maybe we could figure a way to share macros and such between this, pipes and libhdfs??

        Show
        Pete Wyckoff added a comment - NOTE: I renamed some of the macros from FB_blah to FUSE_DFS_blah; longer term, maybe we could figure a way to share macros and such between this, pipes and libhdfs??
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12383317/patch0.txt
        against trunk revision 662913.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2555/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12383317/patch0.txt against trunk revision 662913. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2555/console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12383317/patch0.txt
        against trunk revision 662976.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12383317/patch0.txt against trunk revision 662976. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/console This message is automatically generated.
        Hide
        Robert Chansler added a comment -

        Assigning to whomever submitted a patch so as to better manage committing things that are ready for prime time.

        Show
        Robert Chansler added a comment - Assigning to whomever submitted a patch so as to better manage committing things that are ready for prime time.
        Robert Chansler made changes -
        Assignee Pete Wyckoff [ wyckoff ]
        Hide
        dhruba borthakur added a comment -

        +1. Code looks good.

        Show
        dhruba borthakur added a comment - +1. Code looks good.
        Hide
        dhruba borthakur added a comment -

        I juts committed this. Thanks Pete!

        Show
        dhruba borthakur added a comment - I juts committed this. Thanks Pete!
        dhruba borthakur made changes -
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.18.0 [ 12312972 ]
        Nigel Daley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Owen O'Malley made changes -
        Component/s contrib/fuse-dfs [ 12312376 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3d 20h 42m 1 Pete Wyckoff 03/Jun/08 21:00
        Patch Available Patch Available Resolved Resolved
        22h 1m 1 dhruba borthakur 04/Jun/08 19:02
        Resolved Resolved Closed Closed
        79d 1h 47m 1 Nigel Daley 22/Aug/08 20:50

          People

          • Assignee:
            Pete Wyckoff
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development