Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-3401

Update FileBench to use the "work" directory for SequenceFileOutputFormat

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.18.0
    • test
    • None
    • Reviewed

    Description

      HADOOP-3041 changed SequenceFileOutputFormat::getRecordReader to use a different property for its output path. This is set by a package-private, static function in FileOutputFormat. Since FileBench uses this OutputFormat directly and is not in o.a.h.mapred, it either needs to specify this parameter manually or setWorkOutputPath needs to be public.

      Attachments

        1. 3401-0.patch
          3 kB
          Christopher Douglas

        Activity

          This patch sets the property manually. It's a hack, but it's in test code, so it's probably OK. Also added a unit test.

          cdouglas Christopher Douglas added a comment - This patch sets the property manually. It's a hack, but it's in test code, so it's probably OK. Also added a unit test.
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12382151/3401-0.patch
          against trunk revision 656904.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12382151/3401-0.patch against trunk revision 656904. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2484/console This message is automatically generated.
          omalley Owen O'Malley added a comment -

          I just committed this. Thanks, Chris!

          omalley Owen O'Malley added a comment - I just committed this. Thanks, Chris!
          hudson Hudson added a comment -
          hudson Hudson added a comment - Integrated in Hadoop-trunk #509 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/509/ )

          People

            cdouglas Christopher Douglas
            cdouglas Christopher Douglas
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: