Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.18.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Changed the default port for "hdfs:" URIs to be 8020, so that one may simply use URIs of the form "hdfs://example.com/dir/file".

      Description

      Perhaps we should add a default port number for the HDFS namenode. This would simplify URIs. Instead of hdfs://host.net:9999/foo/bar folks would be able to just use hdfs://host.net/foo/bar in most cases. Thoughts?

      1. HADOOP-3317.patch
        8 kB
        Doug Cutting
      2. HADOOP-3317.patch
        31 kB
        Doug Cutting
      3. HADOOP-3317.patch
        34 kB
        Doug Cutting
      4. HADOOP-3317.patch
        34 kB
        Doug Cutting

        Issue Links

          Activity

          Hide
          Doug Cutting added a comment -

          In case I wasn't clear, this would be analogous to port 80 as the default port for HTTP.

          Show
          Doug Cutting added a comment - In case I wasn't clear, this would be analogous to port 80 as the default port for HTTP.
          Hide
          Owen O'Malley added a comment -

          +1

          Show
          Owen O'Malley added a comment - +1
          Hide
          Doug Cutting added a comment -

          Here's an implementation of this, using the default port of 8020.

          Is 8020 a good default port for namenodes? That's what's used within Y!, but http://www.iana.org/assignments/port-numbers shows it assigned to some Intuit protocol. Do we care?

          Show
          Doug Cutting added a comment - Here's an implementation of this, using the default port of 8020. Is 8020 a good default port for namenodes? That's what's used within Y!, but http://www.iana.org/assignments/port-numbers shows it assigned to some Intuit protocol. Do we care?
          Hide
          steve_l added a comment -

          SANS doesnt list 8020 as a port used by popular malware, that being something you want to avoid unless you want to upset your network security team
          http://www.sans.org/resources/idfaq/oddports.php

          Show
          steve_l added a comment - SANS doesnt list 8020 as a port used by popular malware, that being something you want to avoid unless you want to upset your network security team http://www.sans.org/resources/idfaq/oddports.php
          Hide
          Doug Cutting added a comment -

          New patch that updates documentation accordingly.

          Show
          Doug Cutting added a comment - New patch that updates documentation accordingly.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12381261/HADOOP-3317.patch
          against trunk revision 645773.

          @author +1. The patch does not contain any @author tags.

          tests included +1. The patch appears to include 3 new or modified tests.

          javadoc +1. The javadoc tool did not generate any warning messages.

          javac +1. The applied patch does not generate any new javac compiler warnings.

          release audit +1. The applied patch does not generate any new release audit warnings.

          findbugs +1. The patch does not introduce any new Findbugs warnings.

          core tests +1. The patch passed core unit tests.

          contrib tests +1. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2357/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2357/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2357/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2357/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12381261/HADOOP-3317.patch against trunk revision 645773. @author +1. The patch does not contain any @author tags. tests included +1. The patch appears to include 3 new or modified tests. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2357/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2357/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2357/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2357/console This message is automatically generated.
          Hide
          Owen O'Malley added a comment -

          I'm not wild about adding things that are local to the NameNode into FSConstants. (Actually, the idiom of FSConstants, which just provides constants via inheritance is considered an anti-pattern...) A static final in NameNode would be better, but it is a nit.

          The bigger problem is that you don't have any unit tests. You can't do a system test, because we don't allow fixed ports in the unit tests, but you can parse the string and get the uri.

          The static method NameNode.getUri is passed a NameNode and therefore shouldn't be static.

          Show
          Owen O'Malley added a comment - I'm not wild about adding things that are local to the NameNode into FSConstants. (Actually, the idiom of FSConstants, which just provides constants via inheritance is considered an anti-pattern...) A static final in NameNode would be better, but it is a nit. The bigger problem is that you don't have any unit tests. You can't do a system test, because we don't allow fixed ports in the unit tests, but you can parse the string and get the uri. The static method NameNode.getUri is passed a NameNode and therefore shouldn't be static.
          Hide
          Doug Cutting added a comment -

          > A static final in NameNode would be better, but it is a nit.

          Good idea. I moved the constant to NameNode.

          > The bigger problem is that you don't have any unit tests

          Good point. I've added some unit tests.

          > The static method NameNode.getUri is passed a NameNode and therefore shouldn't be static.

          The parameter is named "namenode" but it's an InetSocketAddress.

          Show
          Doug Cutting added a comment - > A static final in NameNode would be better, but it is a nit. Good idea. I moved the constant to NameNode. > The bigger problem is that you don't have any unit tests Good point. I've added some unit tests. > The static method NameNode.getUri is passed a NameNode and therefore shouldn't be static. The parameter is named "namenode" but it's an InetSocketAddress.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12381328/HADOOP-3317.patch
          against trunk revision 645773.

          @author +1. The patch does not contain any @author tags.

          tests included +1. The patch appears to include 6 new or modified tests.

          javadoc +1. The javadoc tool did not generate any warning messages.

          javac +1. The applied patch does not generate any new javac compiler warnings.

          release audit +1. The applied patch does not generate any new release audit warnings.

          findbugs -1. The patch appears to introduce 1 new Findbugs warnings.

          core tests +1. The patch passed core unit tests.

          contrib tests +1. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2369/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2369/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2369/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2369/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12381328/HADOOP-3317.patch against trunk revision 645773. @author +1. The patch does not contain any @author tags. tests included +1. The patch appears to include 6 new or modified tests. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs -1. The patch appears to introduce 1 new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2369/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2369/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2369/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2369/console This message is automatically generated.
          Hide
          Doug Cutting added a comment -

          Doh! Forgot to make the constant final...

          Show
          Doug Cutting added a comment - Doh! Forgot to make the constant final...
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12381448/HADOOP-3317.patch
          against trunk revision 653611.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2400/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2400/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2400/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2400/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12381448/HADOOP-3317.patch against trunk revision 653611. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2400/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2400/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2400/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2400/console This message is automatically generated.
          Hide
          Owen O'Malley added a comment -

          +1

          Show
          Owen O'Malley added a comment - +1
          Hide
          Hudson added a comment -
          Show
          Hudson added a comment - Integrated in Hadoop-trunk #483 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/483/ )
          Hide
          Hudson added a comment -
          Show
          Hudson added a comment - Integrated in Hadoop-trunk #537 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/537/ )

            People

            • Assignee:
              Doug Cutting
              Reporter:
              Doug Cutting
            • Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development