Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-3263

job history browser throws exception if job name or user name is null.

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 0.17.0
    • 0.17.0
    • None
    • None

    Description

      Job history browser throws exception if job name or user name is null. Instead it should print a null string for user/job name if they are null.

      Attachments

        1. HADOOP-3263_20080416.patch
          2 kB
          Arun Murthy
        2. HADOOP-3263_20080416.patch
          2 kB
          Arun Murthy
        3. patch-3263.txt
          1 kB
          Amareshwari Sriramadasu

        Activity

          patch fixing the exception in browser for null user/job name.

          amareshwari Amareshwari Sriramadasu added a comment - patch fixing the exception in browser for null user/job name.
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12380248/patch-3263.txt
          against trunk revision 645773.

          @author +1. The patch does not contain any @author tags.

          tests included -1. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          javadoc +1. The javadoc tool did not generate any warning messages.

          javac +1. The applied patch does not generate any new javac compiler warnings.

          release audit +1. The applied patch does not generate any new release audit warnings.

          findbugs +1. The patch does not introduce any new Findbugs warnings.

          core tests +1. The patch passed core unit tests.

          contrib tests +1. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12380248/patch-3263.txt against trunk revision 645773. @author +1. The patch does not contain any @author tags. tests included -1. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2251/console This message is automatically generated.
          acmurthy Arun Murthy added a comment -

          Amareshwari, can u please regenerate this patch - it won't apply to trunk anymore.

          Also, rather than all the non-null checks in jobhistory.jsp it will be simpler to use the string 'null' for jobname/username if they are null in JobHistory.java... then we won't have to change jobhistory.jsp at all.

          acmurthy Arun Murthy added a comment - Amareshwari, can u please regenerate this patch - it won't apply to trunk anymore. Also, rather than all the non-null checks in jobhistory.jsp it will be simpler to use the string 'null' for jobname/username if they are null in JobHistory.java... then we won't have to change jobhistory.jsp at all.

          Doing not-null check in jobhistory.jsp makes more sense than jobHistory.java, since jobHistory.java can truncate the filename (if it exceeds max_file_name_size) and jsp file should take care of that.

          amareshwari Amareshwari Sriramadasu added a comment - Doing not-null check in jobhistory.jsp makes more sense than jobHistory.java, since jobHistory.java can truncate the filename (if it exceeds max_file_name_size) and jsp file should take care of that.
          acmurthy Arun Murthy added a comment -

          Sigh, I guess you are right.

          However, i just checked: the filename is around 80 characters not including the jobname, so please get rid of the truncation too in JobHistory.java.

          acmurthy Arun Murthy added a comment - Sigh, I guess you are right. However, i just checked: the filename is around 80 characters not including the jobname, so please get rid of the truncation too in JobHistory.java.
          acmurthy Arun Murthy added a comment -

          Proposed fix...

          acmurthy Arun Murthy added a comment - Proposed fix...
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12380325/HADOOP-3263_20080416.patch
          against trunk revision 645773.

          @author +1. The patch does not contain any @author tags.

          tests included -1. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          javadoc +1. The javadoc tool did not generate any warning messages.

          javac +1. The applied patch does not generate any new javac compiler warnings.

          release audit +1. The applied patch does not generate any new release audit warnings.

          findbugs +1. The patch does not introduce any new Findbugs warnings.

          core tests +1. The patch passed core unit tests.

          contrib tests +1. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12380325/HADOOP-3263_20080416.patch against trunk revision 645773. @author +1. The patch does not contain any @author tags. tests included -1. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2256/console This message is automatically generated.
          acmurthy Arun Murthy added a comment -

          Removed the unused MAX_FILENAME_SIZE variable too...

          acmurthy Arun Murthy added a comment - Removed the unused MAX_FILENAME_SIZE variable too...
          omalley Owen O'Malley added a comment -

          +1

          omalley Owen O'Malley added a comment - +1
          acmurthy Arun Murthy added a comment -

          I just committed this.

          acmurthy Arun Murthy added a comment - I just committed this.
          hudson Hudson added a comment -
          hudson Hudson added a comment - Integrated in Hadoop-trunk #463 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/463/ )

          People

            acmurthy Arun Murthy
            amareshwari Amareshwari Sriramadasu
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: