Hadoop Common
  1. Hadoop Common
  2. HADOOP-3135

if the 'mapred.system.dir' in the client jobconf is different from the JobTracker's value job submission fails

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.16.1
    • Fix Version/s: 0.18.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      all

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Changed job submission protocol to not allow submission if the client's value of mapred.system.dir does not match the job tracker's. Deprecated JobConf.getSystemDir(); use JobClient.getSystemDir().

      Description

      Until Hadoop 0.13 or so, at submission time the full path of the job.xml and all supporting files in DFS was given by the client to the jobtracker.

      Since 0.15 onwards (we did not test 0.14) the jobclient is obtaining the job ID from the jobtracker and creating the directory for all the supporting files using the a system-dir computed from the local jobconf.

      Line 696-7 in the JobClient:

      String jobId = jobSubmitClient.getNewJobId();
      Path submitJobDir = new Path(job.getSystemDir(), jobId);

      This makes submissions to fail when the value of the 'mapred.system.dir' on the client is different from the one in the JobTracker.

      A simple way o fixing this would be to introduce a new method in the JobSubmissionProtocol 'getSystemDir()' that would return the jobtracker system dir and use that dir for uploading all the files on submission.


      For the future: A more comprehensive way of this doing would to obtain a base jobConf from the jobtracker, carrying final information for each element and the construct the job.xml on the client using the final semantics. And, in this case the 'mapred.system.dir' property should be set as final in the jobtracker. As there may be some configuration properties that are sensitive and for security reasons should not be exposed to the clients a new flag 'private' could be introduced and only properties that don't have the 'private' flag would be send over from the jobtracker to the jobclient for job.xml resolution.

      1. patch-3135-v7.txt
        22 kB
        Subru Krishnan
      2. patch-3135-v7_2.txt
        24 kB
        Amareshwari Sriramadasu
      3. patch-3135-v7_1.txt
        22 kB
        Subru Krishnan
      4. patch-3135-v6.txt
        28 kB
        Subru Krishnan
      5. patch-3135-v6_3.txt
        27 kB
        Subru Krishnan
      6. patch-3135-v6_2.txt
        28 kB
        Subru Krishnan
      7. patch-3135-v5.txt
        27 kB
        Subru Krishnan
      8. patch-3135-v4.txt
        20 kB
        Subru Krishnan
      9. patch-3135-v3.txt
        18 kB
        Subru Krishnan

        Issue Links

          Activity

          Owen O'Malley made changes -
          Component/s mapred [ 12310690 ]
          Tsz Wo Nicholas Sze made changes -
          Link This issue incorporates HADOOP-3214 [ HADOOP-3214 ]
          Nigel Daley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Robert Chansler made changes -
          Release Note Deprecates JobConf.getSystemDir(). Now the same method is there in the JobClient. Changed job submission protocol to not allow submission if the client's value of mapred.system.dir does not match the job tracker's. Deprecated JobConf.getSystemDir(); use JobClient.getSystemDir().
          Devaraj Das made changes -
          Resolution Fixed [ 1 ]
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Release Note Deprecates JobConf.getSystemDir(). Now the same method is there in the JobClient.
          Amareshwari Sriramadasu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Amareshwari Sriramadasu made changes -
          Attachment patch-3135-v7_2.txt [ 12383539 ]
          Devaraj Das made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Amareshwari Sriramadasu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags [Reviewed]
          Amareshwari Sriramadasu made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Attachment patch-3135-v7_1.txt [ 12383436 ]
          Amareshwari Sriramadasu made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Attachment patch-3135-v7.txt [ 12382776 ]
          Owen O'Malley made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Attachment patch-3135-v6_3.txt [ 12380470 ]
          Subru Krishnan made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Attachment patch-3135-v6_2.txt [ 12380387 ]
          Subru Krishnan made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Attachment patch-3135-v6.txt [ 12380374 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Attachment patch-3135-v5.txt [ 12380251 ]
          Owen O'Malley made changes -
          Fix Version/s 0.18.0 [ 12312972 ]
          Fix Version/s 0.17.0 [ 12312913 ]
          Priority Blocker [ 1 ] Critical [ 2 ]
          Subru Krishnan made changes -
          Link This issue is cloned as HADOOP-3244 [ HADOOP-3244 ]
          Subru Krishnan made changes -
          Link This issue is cloned as HADOOP-3244 [ HADOOP-3244 ]
          Arun C Murthy made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Attachment patch-3135-v4.txt [ 12379705 ]
          Arun C Murthy made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Attachment patch-3135-v2.txt [ 12379235 ]
          Subru Krishnan made changes -
          Attachment patch-3135-v3.txt [ 12379542 ]
          Owen O'Malley made changes -
          Assignee Alejandro Abdelnur [ tucu00 ] Subramaniam Krishnan [ subru ]
          Owen O'Malley made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Attachment patch-3135.txt [ 12379126 ]
          Subru Krishnan made changes -
          Attachment patch-3135-v2.txt [ 12379235 ]
          Devaraj Das made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Subru Krishnan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Subru Krishnan made changes -
          Attachment patch-3135.txt [ 12379126 ]
          Amareshwari Sriramadasu made changes -
          Assignee Amareshwari Sriramadasu [ amareshwari ] Alejandro Abdelnur [ tucu00 ]
          Devaraj Das made changes -
          Field Original Value New Value
          Assignee Amareshwari Sriramadasu [ amareshwari ]
          Alejandro Abdelnur created issue -

            People

            • Assignee:
              Subru Krishnan
              Reporter:
              Alejandro Abdelnur
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development