Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-3030

InMemoryFileSystem.reserveSpaceWithChecksum does not look at failures while reserving space for the file in question

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.17.0
    • fs
    • None

    Description

      The return statement code in InMemoryFileSystem.reserveSpaceWithCheckSum looks like

        return (mfs.reserveSpace(f, size) && mfs.reserveSpace(getChecksumFile(f), checksumSize));
      

      This should be broken up to check for successful reserveSpace for each of the components. In some cases, we might reserve space for the first component and fail while doing the same for the second (checksum file). This will lead to wastage of space since we don't un-reserve the space we got for the first component. This usually won't happen due to the policy associated with creating a file in the InMemoryFileSystem (since the checksum component is usually very small) but still it should be fixed.

      Attachments

        1. hadoop-3030.patch
          1 kB
          Devaraj Das
        2. 3030.patch
          1 kB
          Devaraj Das

        Activity

          People

            ddas Devaraj Das
            ddas Devaraj Das
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: