Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.14.0
    • Fix Version/s: 0.17.0
    • Component/s: test
    • Labels:
      None

      Description

      The distributed upgrades were tested in the case of one distributed upgrade only.
      It turned out to be that current implementation of the framework does not support multiple upgrades.
      This feature is needed for the appends. See HADOOP-2656.

      1. DistrUpgrade.patch
        14 kB
        Konstantin Shvachko

        Issue Links

          Activity

          Hide
          shv Konstantin Shvachko added a comment -

          This patch fixes the following problems.

          • Ordering of the registered distributed upgrade objects in UpgradeObjectCollection is corrected.
          • UpgradeManagerDatanode starts a new upgrade when requested by the name-node.
          • I improved the upgrade state reporting.
          • TestDistributedUpgrade is testing 3 sequential upgrades now from a pre-upgrade data (LV=-3).
            It uses TestDFSUpgradeFromImage in order to unpack the storage.
          • I separate the unpacking method into TestDFSUpgradeFromImage.unpackStorage()
          • I also turned off the block scanner for both of these tests, because the name-node is in safe mode most of the time,
            and the scanner is just receiving safe-mode exceptions, which only slows down the tests.
          Show
          shv Konstantin Shvachko added a comment - This patch fixes the following problems. Ordering of the registered distributed upgrade objects in UpgradeObjectCollection is corrected. UpgradeManagerDatanode starts a new upgrade when requested by the name-node. I improved the upgrade state reporting. TestDistributedUpgrade is testing 3 sequential upgrades now from a pre-upgrade data (LV=-3). It uses TestDFSUpgradeFromImage in order to unpack the storage. I separate the unpacking method into TestDFSUpgradeFromImage.unpackStorage() I also turned off the block scanner for both of these tests, because the name-node is in safe mode most of the time, and the scanner is just receiving safe-mode exceptions, which only slows down the tests.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12377571/DistrUpgrade.patch
          against trunk revision 619744.

          @author +1. The patch does not contain any @author tags.

          tests included +1. The patch appears to include 6 new or modified tests.

          javadoc +1. The javadoc tool did not generate any warning messages.

          javac +1. The applied patch does not generate any new javac compiler warnings.

          release audit +1. The applied patch does not generate any new release audit warnings.

          findbugs +1. The patch does not introduce any new Findbugs warnings.

          core tests +1. The patch passed core unit tests.

          contrib tests +1. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1940/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1940/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1940/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1940/console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12377571/DistrUpgrade.patch against trunk revision 619744. @author +1. The patch does not contain any @author tags. tests included +1. The patch appears to include 6 new or modified tests. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1940/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1940/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1940/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1940/console This message is automatically generated.
          Hide
          rangadi Raghu Angadi added a comment -

          +1.

          Show
          rangadi Raghu Angadi added a comment - +1.
          Hide
          dhruba dhruba borthakur added a comment -

          I just committed this. Thanks Konstantin!

          Show
          dhruba dhruba borthakur added a comment - I just committed this. Thanks Konstantin!
          Hide
          hudson Hudson added a comment -
          Show
          hudson Hudson added a comment - Integrated in Hadoop-trunk #429 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/429/ )

            People

            • Assignee:
              shv Konstantin Shvachko
              Reporter:
              shv Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development