Hadoop Common
  1. Hadoop Common
  2. HADOOP-2851

Bogus logging messages in Configration object constructors

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Won't Fix
    • Affects Version/s: 0.16.0
    • Fix Version/s: None
    • Component/s: conf
    • Labels:
      None

      Description

      The constructors for the Configuration object contains a superfluous logging message that logs an IOException whenever logging is enabled for the debug level. Basically both constructors have the statement:

      if (LOG.isDebugEnabled())

      { LOG.debug(StringUtils.stringifyException(new IOException("config()"))); }

      I can' t see any reason for it to be there and it just ends up leaving bogus IOExceptions in log files. It looks like its an old debug print statement which has accidentally been left in.

      1. 2851_20080925.patch
        1 kB
        Tsz Wo Nicholas Sze
      2. 2851_20081103.patch
        3 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        Seem that this is not needed. Closing this as "Won't Fix".

        Show
        Tsz Wo Nicholas Sze added a comment - Seem that this is not needed. Closing this as "Won't Fix".
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Talked to Chris: these debug messages do not seem useful. So they are better removed.

        2851_20081103.patch: removed the debug messages and fixed all unchecked warning in Configuration.

        Show
        Tsz Wo Nicholas Sze added a comment - Talked to Chris: these debug messages do not seem useful. So they are better removed. 2851_20081103.patch: removed the debug messages and fixed all unchecked warning in Configuration.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        2851_20080925.patch: use trace level instead of debug level.

        Show
        Tsz Wo Nicholas Sze added a comment - 2851_20080925.patch: use trace level instead of debug level.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Since it is showing stack trace, how about change the log level from debug to trace?

        Show
        Tsz Wo Nicholas Sze added a comment - Since it is showing stack trace, how about change the log level from debug to trace?
        Hide
        steve_l added a comment -

        looks like someone wants a way to get a stack trace of wherever a configuration is created. Sometimes that could be useful. As it is only done if the debug log is enabled, its cost is otherwise minimal.

        Recommend leaving as is, file as INVALID or WONTFIX.

        Show
        steve_l added a comment - looks like someone wants a way to get a stack trace of wherever a configuration is created. Sometimes that could be useful. As it is only done if the debug log is enabled, its cost is otherwise minimal. Recommend leaving as is, file as INVALID or WONTFIX.

          People

          • Assignee:
            Unassigned
            Reporter:
            Jingkei Ly
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development