Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.17.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Hide
      The following deprecated methods are removed from org.apache.hadoop.JobConf :
      public Class getInputKeyClass()
      public void setInputKeyClass(Class theClass)
      public Class getInputValueClass()
      public void setInputValueClass(Class theClass)

      The methods, public boolean org.apache.hadoop.JobConf.getSpeculativeExecution() and
      public void org.apache.hadoop.JobConf.setSpeculativeExecution(boolean speculativeExecution) are undeprecated.
      Show
      The following deprecated methods are removed from org.apache.hadoop.JobConf : public Class getInputKeyClass() public void setInputKeyClass(Class theClass) public Class getInputValueClass() public void setInputValueClass(Class theClass) The methods, public boolean org.apache.hadoop.JobConf.getSpeculativeExecution() and public void org.apache.hadoop.JobConf.setSpeculativeExecution(boolean speculativeExecution) are undeprecated.

      Description

      The following methods in JobConf
      getInputKeyClass()
      setInputKeyClass
      getInputValueClass()
      setInputValueClass(Class theClass)
      setSpeculativeExecution
      getSpeculativeExecution()
      need to be removed as there are deprecated methods lying around.

      1. patch-2819.txt
        7 kB
        Amareshwari Sriramadasu

        Activity

        Hide
        Owen O'Malley added a comment -

        I think we should un-deprecate get/set SpeculativeExecution and make them call the new ones:

        getSpeculativeExecution = getMapSpeculativeExecution or getReduceSpeculativeExecution
        setSpeculativeExecution = setMapSpeculativeExecution adn setReduceSpeculativeExecution

        Show
        Owen O'Malley added a comment - I think we should un-deprecate get/set SpeculativeExecution and make them call the new ones: getSpeculativeExecution = getMapSpeculativeExecution or getReduceSpeculativeExecution setSpeculativeExecution = setMapSpeculativeExecution adn setReduceSpeculativeExecution
        Hide
        Amareshwari Sriramadasu added a comment -

        getSpeculativeExecution = getMapSpeculativeExecution or getReduceSpeculativeExecution

        Is this a boolean OR operation? i.e. getSpeculativeExecutaion returns true when one of

        {map/reduce}

        speculative executation is set to true ?

        Show
        Amareshwari Sriramadasu added a comment - getSpeculativeExecution = getMapSpeculativeExecution or getReduceSpeculativeExecution Is this a boolean OR operation? i.e. getSpeculativeExecutaion returns true when one of {map/reduce} speculative executation is set to true ?
        Hide
        Owen O'Malley added a comment -

        I think that makes sense, doesn't it?

        Show
        Owen O'Malley added a comment - I think that makes sense, doesn't it?
        Hide
        Amareshwari Sriramadasu added a comment -

        ok. that makes sense.
        submitted patch for same.

        Show
        Amareshwari Sriramadasu added a comment - ok. that makes sense. submitted patch for same.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12376603/patch-2819.txt
        against trunk revision 619744.

        @author +1. The patch does not contain any @author tags.

        tests included +1. The patch appears to include 18 new or modified tests.

        javadoc +1. The javadoc tool did not generate any warning messages.

        javac +1. The applied patch does not generate any new javac compiler warnings.

        release audit +1. The applied patch does not generate any new release audit warnings.

        findbugs +1. The patch does not introduce any new Findbugs warnings.

        core tests +1. The patch passed core unit tests.

        contrib tests +1. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1852/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1852/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1852/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1852/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12376603/patch-2819.txt against trunk revision 619744. @author +1. The patch does not contain any @author tags. tests included +1. The patch appears to include 18 new or modified tests. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1852/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1852/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1852/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1852/console This message is automatically generated.
        Hide
        Devaraj Das added a comment -

        I just committed this. Thanks, Amareshwari!

        Show
        Devaraj Das added a comment - I just committed this. Thanks, Amareshwari!
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #419 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/419/ )

          People

          • Assignee:
            Amareshwari Sriramadasu
            Reporter:
            Amareshwari Sriramadasu
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development