Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-2469

WritableUtils.clone should take Configuration rather than JobConf

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.16.0
    • io
    • None

    Description

      I'd like to use WritableUtils.clone but I'm not in a mapred context so don't have a JobConf to hand. I do have a Configuration.

      Looking inside the clone implementation, it doesn't need JobConf; a Configuration will do.

      Attachments

        1. clone.patch
          0.8 kB
          Michael Stack

        Activity

          stack Michael Stack created issue -
          stack Michael Stack added a comment -

          Patch to change clone so takes lower-common-denominator Configuration instead.

          stack Michael Stack added a comment - Patch to change clone so takes lower-common-denominator Configuration instead.
          stack Michael Stack made changes -
          Field Original Value New Value
          Attachment clone.patch [ 12371991 ]
          stack Michael Stack added a comment -

          Trying hudson.

          stack Michael Stack added a comment - Trying hudson.
          stack Michael Stack made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12371991/clone.patch
          against trunk revision r605675.

          @author +1. The patch does not contain any @author tags.

          javadoc +1. The javadoc tool did not generate any warning messages.

          javac +1. The applied patch does not generate any new compiler warnings.

          findbugs +1. The patch does not introduce any new Findbugs warnings.

          core tests +1. The patch passed core unit tests.

          contrib tests +1. The patch passed contrib unit tests.

          Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1400/testReport/
          Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1400/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1400/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1400/console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12371991/clone.patch against trunk revision r605675. @author +1. The patch does not contain any @author tags. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new compiler warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1400/testReport/ Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1400/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1400/artifact/trunk/build/test/checkstyle-errors.html Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1400/console This message is automatically generated.
          acmurthy Arun Murthy added a comment -

          This is source compatible, but not binary compatible... should I commit as-is?

          acmurthy Arun Murthy added a comment - This is source compatible , but not binary compatible... should I commit as-is?
          acmurthy Arun Murthy made changes -
          Fix Version/s 0.16.0 [ 12312740 ]
          Assignee stack [ stack ]
          omalley Owen O'Malley added a comment -

          I think so. It is an unlikely method for users to call...

          omalley Owen O'Malley added a comment - I think so. It is an unlikely method for users to call...
          ddas Devaraj Das added a comment -

          It is true that it is unlikely but can we not have a new API that takes Configuration ? That should handle all cases, no?

          ddas Devaraj Das added a comment - It is true that it is unlikely but can we not have a new API that takes Configuration ? That should handle all cases, no?
          omalley Owen O'Malley added a comment -

          I just committed this. Thanks, Stack!

          omalley Owen O'Malley added a comment - I just committed this. Thanks, Stack!
          omalley Owen O'Malley made changes -
          Resolution Fixed [ 1 ]
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          nidaley Nigel Daley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            stack Michael Stack
            stack Michael Stack
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: