Hadoop Common
  1. Hadoop Common
  2. HADOOP-2460

NameNode could delete wrong edits file when there is an error

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.15.0
    • Fix Version/s: 0.15.2
    • Component/s: None
    • Labels:
      None

      Description

      On one of the clusters two namenode directories were specified. The second directory had errors and edits log sync failed. Namenode was supposed to run with the good directory, but it exited with a 'fatal error' message.

      Looks like it is caused by a bug in processIOError() in FSEditsLog.java. It removes the wrong directory since it passes in index into errorStreams rather than index into editStreams by mistake.

      This probably should go in 0.15.2.

      1. HADOOP-2460.patch
        1.0 kB
        Raghu Angadi

        Activity

        Hide
        Raghu Angadi added a comment - - edited

        Suggested patch. I tested this patch with a forced failure.

        Show
        Raghu Angadi added a comment - - edited Suggested patch. I tested this patch with a forced failure.
        Hide
        dhruba borthakur added a comment -

        +1. Code looks good.

        Show
        dhruba borthakur added a comment - +1. Code looks good.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12371903/HADOOP-2460.patch
        against trunk revision r605299.

        @author +1. The patch does not contain any @author tags.

        javadoc +1. The javadoc tool did not generate any warning messages.

        javac +1. The applied patch does not generate any new compiler warnings.

        findbugs +1. The patch does not introduce any new Findbugs warnings.

        core tests +1. The patch passed core unit tests.

        contrib tests -1. The patch failed contrib unit tests.

        Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/testReport/
        Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12371903/HADOOP-2460.patch against trunk revision r605299. @author +1. The patch does not contain any @author tags. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new compiler warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests -1. The patch failed contrib unit tests. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/testReport/ Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/artifact/trunk/build/test/checkstyle-errors.html Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1387/console This message is automatically generated.
        Hide
        Raghu Angadi added a comment -

        Test failure looks unrelated. The patch applies to both trunk and branch-0.15.

        Show
        Raghu Angadi added a comment - Test failure looks unrelated. The patch applies to both trunk and branch-0.15.
        Hide
        dhruba borthakur added a comment -

        I just committed this. Thanks Raghu!

        Show
        dhruba borthakur added a comment - I just committed this. Thanks Raghu!
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-Nightly #338 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/338/ )

          People

          • Assignee:
            dhruba borthakur
            Reporter:
            Raghu Angadi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development