Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.15.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Trash opens FileSystem using Path.getFileSystem() but never closes it.
      This happens even if Trash is disabled (trash.interval == 0).
      I think trash should not open file system if it is disabled.
      I also think that NameNode should not create a trash Thread when trash is disabled, see NameNode.init().

      1. TrashClose.patch
        3 kB
        Konstantin Shvachko

        Issue Links

          Activity

          Hide
          shv Konstantin Shvachko added a comment -

          I realized I cannot continue with streaming edits HADOOP-4539 without fixing this becasue the standby node is not supposed to run trash.
          So this is the patch, which

          • does not start Trash thread if trash is disabled
          • closes FileSystem when Trash.Emptier exits
          • also cleanded up warnings in TestTrash.
          Show
          shv Konstantin Shvachko added a comment - I realized I cannot continue with streaming edits HADOOP-4539 without fixing this becasue the standby node is not supposed to run trash. So this is the patch, which does not start Trash thread if trash is disabled closes FileSystem when Trash.Emptier exits also cleanded up warnings in TestTrash.
          Hide
          chris.douglas Chris Douglas added a comment -

          +1

          Show
          chris.douglas Chris Douglas added a comment - +1
          Hide
          shv Konstantin Shvachko added a comment -

          Only one unit test failure with this patch. TestMapReduceLocal fails as in HADOOP-4907.

          Show
          shv Konstantin Shvachko added a comment - Only one unit test failure with this patch. TestMapReduceLocal fails as in HADOOP-4907 .
          Hide
          shv Konstantin Shvachko added a comment -

          I just committed this.

          Show
          shv Konstantin Shvachko added a comment - I just committed this.

            People

            • Assignee:
              shv Konstantin Shvachko
              Reporter:
              shv Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development