Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.15.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Trash opens FileSystem using Path.getFileSystem() but never closes it.
      This happens even if Trash is disabled (trash.interval == 0).
      I think trash should not open file system if it is disabled.
      I also think that NameNode should not create a trash Thread when trash is disabled, see NameNode.init().

      1. TrashClose.patch
        3 kB
        Konstantin Shvachko

        Issue Links

          Activity

          Konstantin Shvachko created issue -
          Nigel Daley made changes -
          Field Original Value New Value
          Fix Version/s 0.16.0 [ 12312740 ]
          Hide
          Konstantin Shvachko added a comment -

          I realized I cannot continue with streaming edits HADOOP-4539 without fixing this becasue the standby node is not supposed to run trash.
          So this is the patch, which

          • does not start Trash thread if trash is disabled
          • closes FileSystem when Trash.Emptier exits
          • also cleanded up warnings in TestTrash.
          Show
          Konstantin Shvachko added a comment - I realized I cannot continue with streaming edits HADOOP-4539 without fixing this becasue the standby node is not supposed to run trash. So this is the patch, which does not start Trash thread if trash is disabled closes FileSystem when Trash.Emptier exits also cleanded up warnings in TestTrash.
          Konstantin Shvachko made changes -
          Attachment TrashClose.patch [ 12397588 ]
          Konstantin Shvachko made changes -
          Link This issue blocks HADOOP-4539 [ HADOOP-4539 ]
          Konstantin Shvachko made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Konstantin Shvachko [ shv ]
          Fix Version/s 0.21.0 [ 12313563 ]
          Hide
          Chris Douglas added a comment -

          +1

          Show
          Chris Douglas added a comment - +1
          Chris Douglas made changes -
          Hadoop Flags [Reviewed]
          Hide
          Konstantin Shvachko added a comment -

          Only one unit test failure with this patch. TestMapReduceLocal fails as in HADOOP-4907.

          Show
          Konstantin Shvachko added a comment - Only one unit test failure with this patch. TestMapReduceLocal fails as in HADOOP-4907 .
          Konstantin Shvachko made changes -
          Comment [ +1 ]
          Hide
          Konstantin Shvachko added a comment -

          I just committed this.

          Show
          Konstantin Shvachko added a comment - I just committed this.
          Konstantin Shvachko made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Owen O'Malley made changes -
          Component/s dfs [ 12310710 ]
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          403d 3h 21m 1 Konstantin Shvachko 10/Jan/09 03:01
          Patch Available Patch Available Resolved Resolved
          4d 22h 22m 1 Konstantin Shvachko 15/Jan/09 01:24
          Resolved Resolved Closed Closed
          586d 19h 9m 1 Tom White 24/Aug/10 21:33

            People

            • Assignee:
              Konstantin Shvachko
              Reporter:
              Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development