Hadoop Common
  1. Hadoop Common
  2. HADOOP-2318

All C++ builds should use the autoconf tools

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: build
    • Labels:
      None

      Description

      Currently we have -Dcompile.native and -Dcompile.c++ build flags. In addition, builds for pipes and libhadoop use autoconf tools, but libhdfs does not, nor does 64bit libhdfs compile work.

      All these builds should use autoconf tools, support 64bit compilation, and should occur when a single flag is present (-Dcompile.c++ seems like the better choice).

      1. hadoop-2318.patch
        1.19 MB
        Giridharan Kesavan

        Issue Links

          Activity

          Hide
          Giridharan Kesavan added a comment -

          Except librecordio all other components are now ported to use autotools.
          Here with submitting a patch that enables librecordio to use autotools
          The compilation part works just fine, though the test compilation fails with error

          And now as any other c++ component librecordio.a file is moved to a new location:

          build/c++/<Linux><amd64><64>/lib/librecordio.a

          [exec] Run test
          [exec] Makefile:236: ../hadoop-core-trunk-librecordio/src/c++/librecordio/.deps/%.Po: No such file or directory
          [exec] make[1]: *** No rule to make target `../hadoop-core-trunk-librecordio/src/c++/librecordio/.deps/%.Po'. Stop.
          [exec] make: *** [test] Error 2

          I need some pointers on solving this issue.

          Thanks
          Giri

          Show
          Giridharan Kesavan added a comment - Except librecordio all other components are now ported to use autotools. Here with submitting a patch that enables librecordio to use autotools The compilation part works just fine, though the test compilation fails with error And now as any other c++ component librecordio.a file is moved to a new location: build/c++/<Linux> <amd64> <64>/lib/librecordio.a [exec] Run test [exec] Makefile:236: ../hadoop-core-trunk-librecordio/src/c++/librecordio/.deps/%.Po: No such file or directory [exec] make [1] : *** No rule to make target `../hadoop-core-trunk-librecordio/src/c++/librecordio/.deps/%.Po'. Stop. [exec] make: *** [test] Error 2 I need some pointers on solving this issue. Thanks Giri
          Hide
          Brian Bockelman added a comment -

          AFAICT, this is crufty. In trunk/, libhdfs uses autoconf. Can I close this?

          Show
          Brian Bockelman added a comment - AFAICT, this is crufty. In trunk/, libhdfs uses autoconf. Can I close this?
          Hide
          Colin Patrick McCabe added a comment -

          As Brian Bockelman pointed out more than a year ago, this is way out of date. We now use Maven and CMake in trunk.

          Even in branch-1, the complaints listed here are way out of date. libhdfs compiles with autotools in branch-1, and the 64-bit compile does work for libhdfs in branch-1.

          Please reopen this with a different description (and possibly target-version) if there's still something to address.

          Show
          Colin Patrick McCabe added a comment - As Brian Bockelman pointed out more than a year ago, this is way out of date. We now use Maven and CMake in trunk. Even in branch-1, the complaints listed here are way out of date. libhdfs compiles with autotools in branch-1, and the 64-bit compile does work for libhdfs in branch-1. Please reopen this with a different description (and possibly target-version) if there's still something to address.
          Hide
          Eli Collins added a comment -

          I think we can close this out.

          Show
          Eli Collins added a comment - I think we can close this out.

            People

            • Assignee:
              Giridharan Kesavan
              Reporter:
              Nigel Daley
            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development