[HADOOP-18870] CURATOR-599 change broke functionality introduced in HADOOP-18139 and HADOOP-18709

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0, 3.3.5
• Fix Version/s: 3.4.0
• Component/s: common
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Ferenc Erdelyi
• Reporter: Ferenc Erdelyi
• Created: 29/Aug/23 15:04
• Updated: 27/Jan/24 08:10
• Resolved: 07/Sep/23 01:37

Description

Curator PR#391 introduced a default method in the ZooKeeperFactory interface, hence the override of the 4-parameter NewZookeeper method in the HadoopZookeeperFactory class is not taking effect due to this.

Proposing routing the 4-parameter method to a 5-parameter method, which instantiates the ZKClientConfig as the 5th parameter. This is a non-breaking change, as the ZKClientConfig is currently instantiated within the method.

Issue Links

• breaks: HADOOP-18139 Allow configuration of zookeeper server principal
• breaks: HADOOP-18709 Add curator based ZooKeeper communication support over SSL/TLS into the common library
• is caused by: CURATOR-599 Hanging indefinitely on some scenarios since zookeeper.request.timeout cannot be configured (add support for ZKClientConfig)
• links to: GitHub Pull Request #6007